nvmet-tcp: Ensure old keys are freed before replacing new ones#744
Open
blktests-ci[bot] wants to merge 1 commit intolinus-master_basefrom
Open
nvmet-tcp: Ensure old keys are freed before replacing new ones#744blktests-ci[bot] wants to merge 1 commit intolinus-master_basefrom
blktests-ci[bot] wants to merge 1 commit intolinus-master_basefrom
Conversation
Author
|
Upstream branch: d60bc14 |
Author
|
Upstream branch: d60bc14 |
blktests-ci
Bot
force-pushed
the
series/1081786=>linus-master
branch
from
26dd3a4 to
f51b56e
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
6b4d829 to
ceec5ed
Compare
Author
|
Upstream branch: b4e0758 |
blktests-ci
Bot
force-pushed
the
series/1081786=>linus-master
branch
from
f51b56e to
bfabb65
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
ceec5ed to
3b54e52
Compare
Author
|
Upstream branch: 6596a02 |
blktests-ci
Bot
force-pushed
the
series/1081786=>linus-master
branch
from
bfabb65 to
b1a7eac
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
3b54e52 to
6a0b974
Compare
Author
|
Upstream branch: 507bd4b |
blktests-ci
Bot
force-pushed
the
series/1081786=>linus-master
branch
from
b1a7eac to
7f70317
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
6a0b974 to
59ca59b
Compare
Author
|
Upstream branch: dd6c438 |
blktests-ci
Bot
force-pushed
the
series/1081786=>linus-master
branch
from
7f70317 to
067ff26
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
2 times, most recently
from
94f0438 to
857ada9
Compare
Author
|
Upstream branch: dd6c438 |
blktests-ci
Bot
force-pushed
the
series/1081786=>linus-master
branch
from
067ff26 to
05acdaf
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
857ada9 to
482ce5b
Compare
Author
|
Upstream branch: dca922e |
blktests-ci
Bot
force-pushed
the
series/1081786=>linus-master
branch
from
05acdaf to
ce07672
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
482ce5b to
5a9f7c7
Compare
Previously after the host sends a REPLACETLSPSK we freed the TLS keys as part of calling nvmet_auth_sq_free() on success. A recent change ensured we don't free the keys, allowing REPLACETLSPSK to work. But that fix results in a kernel memory leak when running ``` nvme_trtype=loop ./check nvme/041 nvme/042 nvme/043 nvme/044 nvme/045 nvme/051 nvme/052 echo scan > /sys/kernel/debug/kmemleak cat /sys/kernel/debug/kmemleak ``` We can't free the keys on a successful DHCHAP operation, otherwise the next REPLACETLSPSK will fail, so instead let's free them before we replace them as part of nvmet_auth_challenge(). This ensures that REPLACETLSPSK works, while also avoiding any memory leaks. Fixes: 2e6eb6b ("nvmet-tcp: Don't free SQ on authentication success") Signed-off-by: Alistair Francis <[email protected]> Reviewed-by: Christoph Hellwig <[email protected]>
Author
|
Upstream branch: e75a43c |
blktests-ci
Bot
force-pushed
the
series/1081786=>linus-master
branch
from
ce07672 to
b0eafac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: nvmet-tcp: Ensure old keys are freed before replacing new ones
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1081786