blk-wbt: use fast inverse square root to optimize window size calculation#73
Closed
blktests-ci[bot] wants to merge 3 commits intofor-next_basefrom
Closed
blk-wbt: use fast inverse square root to optimize window size calculation#73blktests-ci[bot] wants to merge 3 commits intofor-next_basefrom
blktests-ci[bot] wants to merge 3 commits intofor-next_basefrom
Conversation
* block-6.17: block: fix potential deadlock while running nr_hw_queue update block: fix lockdep warning caused by lock dependency in elv_iosched_store block: move elevator queue allocation logic into blk_mq_init_sched blk-ioc: don't hold queue_lock for ioc_lookup_icq() block: Enforce power-of-2 physical block size block: avoid possible overflow for chunk_sectors check in blk_stack_limits() block: Improve read ahead size for rotational devices
* io_uring-6.17: io_uring/net: Allow to do vectorized send
Author
|
Upstream branch: 4643847 Pull request is NOT updated. Failed to apply https://patchwork.kernel.org/project/linux-block/list/?series=986195 conflict: |
blktests-ci
Bot
force-pushed
the
for-next_base
branch
6 times, most recently
from
26415c4 to
3ffa704
Compare
blktests-ci
Bot
force-pushed
the
for-next_base
branch
6 times, most recently
from
651764c to
e438678
Compare
blktests-ci
Bot
force-pushed
the
for-next_base
branch
from
e438678 to
aaa3526
Compare
blktests-ci Bot
pushed a commit
that referenced
this pull request
Jan 27, 2026
Revert commit bfc467d ("serial: remove redundant tty_port_link_device()") because the tty_port_link_device() is not redundant: the tty->port has to be confured before we call uart_configure_port(), otherwise user-space can open console without TTY linked to the driver. This tty_port_link_device() was added explicitly to avoid this exact issue in commit fb2b900 ("tty: link tty and port before configuring it as console"), so offending commit basically reverted the fix saying it is redundant without addressing the actual race condition presented there. Reproducible always as tty->port warning on Qualcomm SoC with most of devices disabled, so with very fast boot, and one serial device being the console: printk: legacy console [ttyMSM0] enabled printk: legacy console [ttyMSM0] enabled printk: legacy bootconsole [qcom_geni0] disabled printk: legacy bootconsole [qcom_geni0] disabled ------------[ cut here ]------------ tty_init_dev: ttyMSM driver does not set tty->port. This would crash the kernel. Fix the driver! WARNING: drivers/tty/tty_io.c:1414 at tty_init_dev.part.0+0x228/0x25c, CPU#2: systemd/1 Modules linked in: socinfo tcsrcc_eliza gcc_eliza sm3_ce fuse ipv6 CPU: 2 UID: 0 PID: 1 Comm: systemd Tainted: G S 6.19.0-rc4-next-20260108-00024-g2202f4d30aa8 #73 PREEMPT Tainted: [S]=CPU_OUT_OF_SPEC Hardware name: Qualcomm Technologies, Inc. Eliza (DT) ... tty_init_dev.part.0 (drivers/tty/tty_io.c:1414 (discriminator 11)) (P) tty_open (arch/arm64/include/asm/atomic_ll_sc.h:95 (discriminator 3) drivers/tty/tty_io.c:2073 (discriminator 3) drivers/tty/tty_io.c:2120 (discriminator 3)) chrdev_open (fs/char_dev.c:411) do_dentry_open (fs/open.c:962) vfs_open (fs/open.c:1094) do_open (fs/namei.c:4634) path_openat (fs/namei.c:4793) do_filp_open (fs/namei.c:4820) do_sys_openat2 (fs/open.c:1391 (discriminator 3)) ... Starting Network Name Resolution... Apparently the flow with this small Yocto-based ramdisk user-space is: driver (qcom_geni_serial.c): user-space: ============================ =========== qcom_geni_serial_probe() uart_add_one_port() serial_core_register_port() serial_core_add_one_port() uart_configure_port() register_console() | | open console | ... | tty_init_dev() | driver->ports[idx] is NULL | tty_port_register_device_attr_serdev() tty_port_link_device() <- set driver->ports[idx] Fixes: bfc467d ("serial: remove redundant tty_port_link_device()") Cc: [email protected] Signed-off-by: Krzysztof Kozlowski <[email protected]> Reviewed-by: Jiri Slaby <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: blk-wbt: use fast inverse square root to optimize window size calculation
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=986195