Skip to content

block: fix atomic write limits for stacked devices #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
blktests-ci wants to merge 2 commits into from
Closed

block: fix atomic write limits for stacked devices #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d460ec
adding ci files
kawasaki Jun 9, 2025
be154d9
block: fix atomic write limits for stacked devices
shroffni Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions .github/workflows/kernel_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
name: blktests-ci

on:
pull_request:

jobs:
build-kernel:
runs-on: ubuntu-latest
steps:
- name: Configure git
run: |
git config --global --add safe.directory '*'
- name: Checkout git
run: |
sudo apt-get install -y libelf-dev
mkdir -p linux
cd linux
git init
git remote add origin https://github.com/${{ github.repository }}
git fetch origin --depth=5 ${{ github.event.pull_request.head.sha }}
git reset --hard ${{ github.event.pull_request.head.sha }}
git log -1
- name: Build kernel
run: |
cd linux
make defconfig
make -j 8

10 changes: 8 additions & 2 deletions block/blk-settings.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,8 +598,14 @@ static bool blk_stack_atomic_writes_head(struct queue_limits *t,
!blk_stack_atomic_writes_boundary_head(t, b))
return false;

if (t->io_min <= SECTOR_SIZE) {
/* No chunk sectors, so use bottom device values directly */
if (t->io_min <= SECTOR_SIZE ||
(!(t->atomic_write_hw_unit_max % t->io_min) &&
!(t->atomic_write_hw_unit_min % t->io_min))) {
/*
* If there are no chunk sectors, or if b->atomic_write_hw_unit
* _{min, max} are aligned to the chunk size (t->io_min), then
* use the bottom device's values directly.
*/
t->atomic_write_hw_unit_max = b->atomic_write_hw_unit_max;
t->atomic_write_hw_unit_min = b->atomic_write_hw_unit_min;
t->atomic_write_hw_max = b->atomic_write_hw_max;
Expand Down