Skip to content

Commit c45c6eb

Browse files
tatyana-enrleon
authored andcommitted
RDMA/irdma: Remove reset check from irdma_modify_qp_to_err()
During reset, irdma_modify_qp() to error should be called to disconnect the QP. Without this fix, if not preceded by irdma_modify_qp() to error, the API call irdma_destroy_qp() gets stuck waiting for the QP refcount to go to zero, because the cm_node associated with this QP isn't disconnected. Fixes: 915cc7a ("RDMA/irdma: Add miscellaneous utility definitions") Signed-off-by: Tatyana Nikolova <[email protected]> Signed-off-by: Leon Romanovsky <[email protected]>
1 parent b415399 commit c45c6eb

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

drivers/infiniband/hw/irdma/utils.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2322,8 +2322,6 @@ void irdma_modify_qp_to_err(struct irdma_sc_qp *sc_qp)
23222322
struct irdma_qp *qp = sc_qp->qp_uk.back_qp;
23232323
struct ib_qp_attr attr;
23242324

2325-
if (qp->iwdev->rf->reset)
2326-
return;
23272325
attr.qp_state = IB_QPS_ERR;
23282326

23292327
if (rdma_protocol_roce(qp->ibqp.device, 1))

0 commit comments

Comments
 (0)