Skip to content

Commit b415399

Browse files
ivandbarrerarleon
authored andcommitted
RDMA/irdma: Clean up unnecessary dereference of event->cm_node
The cm_node is available and the usage of cm_node and event->cm_node seems arbitrary. Clean up unnecessary dereference of event->cm_node. Fixes: 146b975 ("RDMA/irdma: Add connection manager") Signed-off-by: Ivan Barrera <[email protected]> Signed-off-by: Tatyana Nikolova <[email protected]> Signed-off-by: Leon Romanovsky <[email protected]>
1 parent 5e8f023 commit b415399

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

  • drivers/infiniband/hw/irdma

drivers/infiniband/hw/irdma/cm.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4239,21 +4239,21 @@ static void irdma_cm_event_handler(struct work_struct *work)
42394239
irdma_cm_event_reset(event);
42404240
break;
42414241
case IRDMA_CM_EVENT_CONNECTED:
4242-
if (!event->cm_node->cm_id ||
4243-
event->cm_node->state != IRDMA_CM_STATE_OFFLOADED)
4242+
if (!cm_node->cm_id ||
4243+
cm_node->state != IRDMA_CM_STATE_OFFLOADED)
42444244
break;
42454245
irdma_cm_event_connected(event);
42464246
break;
42474247
case IRDMA_CM_EVENT_MPA_REJECT:
4248-
if (!event->cm_node->cm_id ||
4248+
if (!cm_node->cm_id ||
42494249
cm_node->state == IRDMA_CM_STATE_OFFLOADED)
42504250
break;
42514251
irdma_send_cm_event(cm_node, cm_node->cm_id,
42524252
IW_CM_EVENT_CONNECT_REPLY, -ECONNREFUSED);
42534253
break;
42544254
case IRDMA_CM_EVENT_ABORTED:
4255-
if (!event->cm_node->cm_id ||
4256-
event->cm_node->state == IRDMA_CM_STATE_OFFLOADED)
4255+
if (!cm_node->cm_id ||
4256+
cm_node->state == IRDMA_CM_STATE_OFFLOADED)
42574257
break;
42584258
irdma_event_connect_error(event);
42594259
break;
@@ -4263,7 +4263,7 @@ static void irdma_cm_event_handler(struct work_struct *work)
42634263
break;
42644264
}
42654265

4266-
irdma_rem_ref_cm_node(event->cm_node);
4266+
irdma_rem_ref_cm_node(cm_node);
42674267
kfree(event);
42684268
}
42694269

0 commit comments

Comments
 (0)