RDMA/irdma: Remove a NOP wait_event() in irdma_modify_qp_roce()

tatyana-en · rleon · commit 5e8f0239731a · 2026-03-18T06:20:53.000-04:00
Remove a NOP wait_event() in irdma_modify_qp_roce() which is relevant for iWARP and likely a copy and paste artifact for RoCEv2. The wait event is for sending a reset on a TCP connection, after the reset has been requested in irdma_modify_qp(), which occurs only in iWarp mode. Fixes: b48c24c ("RDMA/irdma: Implement device supported verb APIs") Signed-off-by: Tatyana Nikolova <tatyana.e.nikolova@intel.com> Signed-off-by: Leon Romanovsky <leon@kernel.org>
diff --git a/drivers/infiniband/hw/irdma/verbs.c b/drivers/infiniband/hw/irdma/verbs.c
@@ -1462,8 +1462,6 @@ int irdma_modify_qp_roce(struct ib_qp *ibqp, struct ib_qp_attr *attr,
 				ctx_info->remote_atomics_en = true;
 	}
 
-	wait_event(iwqp->mod_qp_waitq, !atomic_read(&iwqp->hw_mod_qp_pend));
-
 	ibdev_dbg(&iwdev->ibdev,
 		  "VERBS: caller: %pS qp_id=%d to_ibqpstate=%d ibqpstate=%d irdma_qpstate=%d attr_mask=0x%x\n",
 		  __builtin_return_address(0), ibqp->qp_num, attr->qp_state,

Original file line number	Diff line number	Diff line change
`@@ -1462,8 +1462,6 @@ int irdma_modify_qp_roce(struct ib_qp ibqp, struct ib_qp_attr attr,`
`1462`	`1462`	`ctx_info->remote_atomics_en = true;`
`1463`	`1463`	`}`
`1464`	`1464`
`1465`		`- wait_event(iwqp->mod_qp_waitq, !atomic_read(&iwqp->hw_mod_qp_pend));`
`1466`		`-`
`1467`	`1465`	`ibdev_dbg(&iwdev->ibdev,`
`1468`	`1466`	`"VERBS: caller: %pS qp_id=%d to_ibqpstate=%d ibqpstate=%d irdma_qpstate=%d attr_mask=0x%x\n",`
`1469`	`1467`	`__builtin_return_address(0), ibqp->qp_num, attr->qp_state,`