Skip to content

Commit 9fb0106

Browse files
Maarten Lankhorstairlied
authored andcommitted
drm/ttm/tests: Remove checks from ttm_pool_free_no_dma_alloc
On !x86, the pool type is never initialised, and the pages are freed back to the system. The test broke on the list_lru rewrite, but I'm not sure how that it was supposed to work previously. In the meantime CI is broken so reverting for now. Fixes: 444e2a1 ("ttm/pool: port to list_lru. (v2)") Cc: Christian Koenig <[email protected]> Cc: Johannes Weiner <[email protected]> Cc: Dave Chinner <[email protected]> Cc: Christian König <[email protected]> Cc: Dave Airlie <[email protected]> Signed-off-by: Maarten Lankhorst <[email protected]> Signed-off-by: Dave Airlie <[email protected]> Link: https://patch.msgid.link/[email protected]
1 parent 3b053cd commit 9fb0106

1 file changed

Lines changed: 0 additions & 6 deletions

File tree

drivers/gpu/drm/ttm/tests/ttm_pool_test.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -368,7 +368,6 @@ static void ttm_pool_free_no_dma_alloc(struct kunit *test)
368368
struct ttm_test_devices *devs = priv->devs;
369369
struct ttm_tt *tt;
370370
struct ttm_pool *pool;
371-
struct ttm_pool_type *pt;
372371
enum ttm_caching caching = ttm_uncached;
373372
unsigned int order = 2;
374373
size_t size = (1 << order) * PAGE_SIZE;
@@ -382,14 +381,9 @@ static void ttm_pool_free_no_dma_alloc(struct kunit *test)
382381
ttm_pool_init(pool, devs->dev, NUMA_NO_NODE, 0);
383382
ttm_pool_alloc(pool, tt, &simple_ctx);
384383

385-
pt = &pool->caching[caching].orders[order];
386-
KUNIT_ASSERT_TRUE(test, list_lru_count(&pt->pages) == 1);
387-
388384
ttm_pool_free(pool, tt);
389385
ttm_tt_fini(tt);
390386

391-
KUNIT_ASSERT_TRUE(test, list_lru_count(&pt->pages) == 1);
392-
393387
ttm_pool_fini(pool);
394388
}
395389

0 commit comments

Comments
 (0)