Skip to content

Commit 3b053cd

Browse files
matt-auldairlied
authored andcommitted
drm/ttm/tests: fix lru_count ASSERT
On pool init we should expect the lru_count for each node to be zeroed as per __list_lru_init -> init_one_lru, but here we are asserting the opposite. Currently our CI is blowing up with: 10:23:33] # ttm_device_init_pools: ASSERTION FAILED at drivers/gpu/drm/ttm/tests/ttm_device_test.c:178 [10:23:33] Expected !list_lru_count(&pt.pages) to be false, but is true [10:23:33] [FAILED] DMA allocations, DMA32 required [10:23:33] [PASSED] No DMA allocations, DMA32 required [10:23:33] # ttm_device_init_pools: ASSERTION FAILED at drivers/gpu/drm/ttm/tests/ttm_device_test.c:178 [10:23:33] Expected !list_lru_count(&pt.pages) to be false, but is true Fixes: 444e2a1 ("ttm/pool: port to list_lru. (v2)") Signed-off-by: Matthew Auld <[email protected]> Cc: Matthew Brost <[email protected]> Cc: Christian Koenig <[email protected]> Cc: Dave Airlie <[email protected]> Reviewed-by: Ryszard Knop <[email protected]> Signed-off-by: Dave Airlie <[email protected]> Link: https://patch.msgid.link/[email protected]
1 parent 650c54b commit 3b053cd

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/gpu/drm/ttm/tests/ttm_device_test.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ static void ttm_device_init_pools(struct kunit *test)
176176

177177
if (ttm_pool_uses_dma_alloc(pool))
178178
KUNIT_ASSERT_FALSE(test,
179-
!list_lru_count(&pt.pages));
179+
list_lru_count(&pt.pages));
180180
}
181181
}
182182
}

0 commit comments

Comments
 (0)