tests: update to use _get_page_size to get PAGE_SIZE#243
tests: update to use _get_page_size to get PAGE_SIZE#243yizhanglinux wants to merge 1 commit intolinux-blktests:masterfrom
Conversation
Signed-off-by: Yi Zhang <[email protected]>
|
@yizhanglinux Thanks! I had noticed that this change is beneficial when you introduced _get_page_size(). As to the patch, I would like to ask three things: 1) zbd/014 has "_have_program getconf" in requires(). This line should be remove together in the patch. 2) The commit message is empty and its title is rather unclear. Let's add test cases modified in the commit title, and explain why this change is good. I suggest the commit message as follows. Also, could you post this patch to linux-block list? This change is not a big deal, but I would like to make sure the change was shared on the list before apply. If you are too busy to handle this, please let me know so that I can help it out. |
|
Per local talk, I modified the patch and posted it to linux-block on behalf of @yizhanglinux. |
Commit 8eca9fa ("common/rc, scsi/011, zbd/010: introduce _page_size_equals() helper") introduced the helper bash function _get_page_size(). Replace "getconf PAGE_SIZE" with the helper to cut dependency to the getconf tool. Link: #243 Signed-off-by: Yi Zhang <[email protected]> [Shin'ichiro: removed getconf command check in zbd/014] Signed-off-by: Shin'ichiro Kawasaki <[email protected]>
|
I applied the modified change. Thank goes to @yizhanglinux. I close this case. |
No description provided.