Skip to content

tests: update to use _get_page_size to get PAGE_SIZE#243

Closed
yizhanglinux wants to merge 1 commit intolinux-blktests:masterfrom
yizhanglinux:use-_get_page_size-to-get-pagesize
Closed

tests: update to use _get_page_size to get PAGE_SIZE#243
yizhanglinux wants to merge 1 commit intolinux-blktests:masterfrom
yizhanglinux:use-_get_page_size-to-get-pagesize

Conversation

@yizhanglinux
Copy link
Copy Markdown
Contributor

No description provided.

@kawasaki
Copy link
Copy Markdown
Collaborator

@yizhanglinux Thanks! I had noticed that this change is beneficial when you introduced _get_page_size().

As to the patch, I would like to ask three things: 1) zbd/014 has "_have_program getconf" in requires(). This line should be remove together in the patch. 2) The commit message is empty and its title is rather unclear. Let's add test cases modified in the commit title, and explain why this change is good. I suggest the commit message as follows.

    throtl/{002,003,007}, zbd/014: use _get_page_size to get PAGE_SIZE

    Commit 8eca9fa369ee ("common/rc, scsi/011, zbd/010: introduce
    _page_size_equals() helper") introduced the helper bash function
    _get_page_size(). Replace "getconf PAGE_SIZE" with the helper to cut
    dependency to the getconf tool.

Also, could you post this patch to linux-block list? This change is not a big deal, but I would like to make sure the change was shared on the list before apply. If you are too busy to handle this, please let me know so that I can help it out.

@kawasaki
Copy link
Copy Markdown
Collaborator

Per local talk, I modified the patch and posted it to linux-block on behalf of @yizhanglinux.

kawasaki pushed a commit that referenced this pull request Apr 22, 2026
Commit 8eca9fa ("common/rc, scsi/011, zbd/010: introduce
_page_size_equals() helper") introduced the helper bash function
_get_page_size(). Replace "getconf PAGE_SIZE" with the helper to cut
dependency to the getconf tool.

Link: #243
Signed-off-by: Yi Zhang <[email protected]>
[Shin'ichiro: removed getconf command check in zbd/014]
Signed-off-by: Shin'ichiro Kawasaki <[email protected]>
@kawasaki
Copy link
Copy Markdown
Collaborator

I applied the modified change. Thank goes to @yizhanglinux. I close this case.

@kawasaki kawasaki closed this Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants