[vpj] Preserve KIF input config precedence - #2974
Open
pthirun wants to merge 1 commit into
Open
Conversation
Forward general Spark input properties before applying the resolved source broker and controller-derived key and KME schemas so stale originals cannot replace authoritative values. Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
Spark Kafka-input repush forwarded all original job properties after applying normalized inputs. A stale source broker, source key schema, or Kafka Message Envelope schema could therefore replace the controller-derived value and make Spark diverge from MapReduce behavior.
Solution
Forward general job properties first, then apply the resolved source broker and controller-derived key and Kafka Message Envelope schemas. This preserves custom adapter and other pass-through properties while keeping authoritative normalized values final.
Code changes
Concurrency-Specific Checks
Both reviewer and PR author to verify
synchronized,RWLock) are used where needed.ConcurrentHashMap,CopyOnWriteArrayList).How was this PR tested?
Ran the focused
DataWriterSparkJobTestsuite, including stale and empty source key schemas, conflicting broker and KME schemas, and custom property forwarding. Ran the repository Spotless check.Does this PR introduce any user-facing or breaking changes?
🤖 Generated with GitHub Copilot CLI