Skip to content

fix(rope): don't mark the unused batch-size param as tl.constexpr #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
vaibhavjindal wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix(rope): don't mark the unused batch-size param as tl.constexpr #1351

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc8838e
fix(rope): don't mark the unused batch-size param as tl.constexpr
vaibhavjindal Aug 7, 2026
60e7955
Merge branch 'main' into fix/rope-dead-constexpr-batch-size-dynamic-s…
vaibhavjindal Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/liger_kernel/ops/rope.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,13 @@ def _triton_rope(
sin,
sin_row_stride,
sl,
bs: tl.constexpr,
# `bs` is unused by the kernel body and is deliberately NOT a tl.constexpr.
# Marking it constexpr forces Triton/Dynamo to specialize on the batch size,
# which fails when torch.compile makes the batch dimension dynamic: the value
# arrives as a SymInt and Dynamo trips an internal assertion while tracing
# LigerRopeFunction ("assert subgraph_vt.is_tensor() or isinstance(
# subgraph_vt, SymNodeVariable)" in _dynamo/variables/higher_order_ops.py).
bs,
cos_bs: tl.constexpr,
n_qh: tl.constexpr,
n_kh: tl.constexpr,
Expand Down
Loading