test: enforce SET_SUPPORT_ACHIEVEMENTS before retro_init; clarify E2E deps

- Run Test 1 immediately after retro_set_environment so regressions that
  move the call into retro_init fail.
- Document libdl on Linux for test_rcheevos_e2e.sh (dlopen via -ldl).

Made-with: Cursor

Author: JoeMatt

test/tools/test_memory_map.c

@@ -180,20 +180,14 @@ int main(int argc, char **argv)
     captured_memmap = NULL;
 
     core_set_env(env_cb);
-    core_set_video(video_cb);
-    core_set_audio(audio_cb);
-    core_set_audio_batch(audio_batch);
-    core_set_input_poll(input_poll);
-    core_set_input_state(input_state);
-    core_init();
 
-    /* Test 1: SET_SUPPORT_ACHIEVEMENTS during retro_set_environment — non-NULL bool, true */
+    /* Test 1: must fire from retro_set_environment before retro_init (not after init) */
     printf("Test 1: SET_SUPPORT_ACHIEVEMENTS (true) ... ");
     if (got_achievements && achievements_data_ok && achievements_enabled_true)
         printf("PASS\n");
     else if (!got_achievements)
     {
-        printf("FAIL (not called)\n");
+        printf("FAIL (not called during retro_set_environment)\n");
         failures++;
     }
     else if (!achievements_data_ok)
@@ -207,6 +201,13 @@ int main(int argc, char **argv)
         failures++;
     }
 
+    core_set_video(video_cb);
+    core_set_audio(audio_cb);
+    core_set_audio_batch(audio_batch);
+    core_set_input_poll(input_poll);
+    core_set_input_state(input_state);
+    core_init();
+
     /* Load the dummy ROM to trigger SET_MEMORY_MAPS */
     rom = make_dummy_rom(&rom_size);
     memset(&info, 0, sizeof(info));

test/tools/test_rcheevos_e2e.sh

@@ -3,7 +3,7 @@
 # memory initialization (same path RetroArch uses for Jaguar / console 17), then read
 # bytes via rc_libretro_memory_read / rc_libretro_memory_find.
 #
-# Requires: bash, curl, cc, ar, dlopen (libc)
+# Requires: bash, curl, cc, ar, libdl (Linux, for dlopen via -ldl)
 # Usage: ./test/tools/test_rcheevos_e2e.sh path/to/virtualjaguar_libretro.{so,dylib}
 set -euo pipefail