PR 117: assert achievements=true, cache rcheevos E2E, clarify CLAUDE.md

- test_memory_map: capture SET_SUPPORT_ACHIEVEMENTS data per libretro.h (non-NULL bool, true).
- CI: actions/cache for build/rcheevos-static keyed by pin + OS + compiler + target.
- CLAUDE.md: distinguish no RA server vs GitHub tarball fetch.

Made-with: Cursor

Author: JoeMatt

.github/workflows/c-cpp.yml

@@ -211,6 +211,13 @@ jobs:
         $CC -O2 -Wall -o test/tools/test_memory_map test/tools/test_memory_map.c $LDFLAGS
         ./test/tools/test_memory_map ./${{ matrix.config.artifact }}
 
+    - name: Cache pinned rcheevos E2E build
+      if: ${{ !matrix.config.emscripten && !matrix.config.android && !matrix.config.cross && runner.os != 'Windows' }}
+      uses: actions/cache@v4
+      with:
+        path: build/rcheevos-static
+        key: rcheevos-e2e-fd57e900-${{ runner.os }}-${{ matrix.config.cc }}-${{ matrix.config.displayTargetName }}
+
     - name: RetroAchievements rc_libretro E2E test
       if: ${{ !matrix.config.emscripten && !matrix.config.android && !matrix.config.cross && runner.os != 'Windows' }}
       env:

CLAUDE.md

@@ -92,10 +92,10 @@ Key docs:
 
 ### Testing
 
-RetroAchievements-related (no RetroAchievements server/API access; local validation only):
+RetroAchievements-related — **no RetroAchievements account, API, or gameplay server**; local validation only. The E2E harness still **fetches the pinned rcheevos source tarball from GitHub** when `build/rcheevos-static` is missing (CI may cache that directory); that is unrelated to contacting RetroAchievements services.
 
-- `test/tools/test_memory_map.c` — asserts `SET_MEMORY_MAPS` / `SET_SUPPORT_ACHIEVEMENTS` and descriptor layout vs `retro_get_memory_data(SYSTEM_RAM)`.
-- `test/tools/test_rcheevos_e2e.sh` — does not contact RetroAchievements services; it downloads pinned **rcheevos** (`RCHEEVOS_REF`, default `v12.3.0`) when needed in a clean environment, builds `librcheevos.a`, then runs `test_rcheevos_e2e` to verify **rc_libretro** memory resolution (`RC_CONSOLE_ATARI_JAGUAR`) matches host RAM — the same mapping stack RetroArch uses before any RA API call. If the pinned tarball/build output is already cached locally, this external download step is avoided.
+- `test/tools/test_memory_map.c` — asserts `SET_MEMORY_MAPS`, `SET_SUPPORT_ACHIEVEMENTS` with **`true`**, and descriptor layout vs `retro_get_memory_data(SYSTEM_RAM)`.
+- `test/tools/test_rcheevos_e2e.sh` — downloads pinned **rcheevos** (`RCHEEVOS_REF`) when needed, builds `librcheevos.a`, then runs `test_rcheevos_e2e` to verify **rc_libretro** memory resolution (`RC_CONSOLE_ATARI_JAGUAR`) matches host RAM — the same mapping stack RetroArch uses before any RA cloud call.
 
 See `docs/test-infrastructure.md` for all test harnesses:
 - `test/test_dsp_mac40.c` — Jaguar DSP **40-bit MAC** accumulator semantics (`dsp_acc40.h`), run in CI with SIMD tests; relevant for long IIR chains (e.g. pink-noise generators on DSP).

test/tools/test_memory_map.c

@@ -2,8 +2,8 @@
  * test_memory_map.c — Verify RetroAchievements memory map advertisement.
  *
  * Loads the core, feeds a minimal dummy ROM, and checks that
- * RETRO_ENVIRONMENT_SET_MEMORY_MAPS and SET_SUPPORT_ACHIEVEMENTS
- * are called with correct values.
+ * RETRO_ENVIRONMENT_SET_MEMORY_MAPS is advertised and SET_SUPPORT_ACHIEVEMENTS
+ * is called with a non-NULL pointer to bool true (per libretro.h).
  *
  * Build:
  *   cc -o test/tools/test_memory_map test/tools/test_memory_map.c -ldl  (Linux)
@@ -44,6 +44,8 @@ typedef size_t (*retro_get_memory_size_t)(unsigned);
 
 static bool got_memory_maps;
 static bool got_achievements;
+static bool achievements_data_ok;
+static bool achievements_enabled_true;
 static const struct retro_memory_map *captured_memmap;
 
 static bool env_cb(unsigned cmd, void *data)
@@ -56,6 +58,11 @@ static bool env_cb(unsigned cmd, void *data)
         return true;
     case RETRO_ENVIRONMENT_SET_SUPPORT_ACHIEVEMENTS:
         got_achievements = true;
+        if (data)
+        {
+            achievements_data_ok = true;
+            achievements_enabled_true = *(const bool *)data;
+        }
         return true;
     case RETRO_ENVIRONMENT_SET_PIXEL_FORMAT:
     case RETRO_ENVIRONMENT_SET_SUPPORT_NO_GAME:
@@ -168,6 +175,8 @@ int main(int argc, char **argv)
 
     got_memory_maps = false;
     got_achievements = false;
+    achievements_data_ok = false;
+    achievements_enabled_true = false;
     captured_memmap = NULL;
 
     core_set_env(env_cb);
@@ -178,15 +187,25 @@ int main(int argc, char **argv)
     core_set_input_state(input_state);
     core_init();
 
-    /* Test 1: SET_SUPPORT_ACHIEVEMENTS called during retro_set_environment */
-    printf("Test 1: SET_SUPPORT_ACHIEVEMENTS ... ");
-    if (got_achievements)
+    /* Test 1: SET_SUPPORT_ACHIEVEMENTS during retro_set_environment — non-NULL bool, true */
+    printf("Test 1: SET_SUPPORT_ACHIEVEMENTS (true) ... ");
+    if (got_achievements && achievements_data_ok && achievements_enabled_true)
         printf("PASS\n");
-    else
+    else if (!got_achievements)
     {
         printf("FAIL (not called)\n");
         failures++;
     }
+    else if (!achievements_data_ok)
+    {
+        printf("FAIL (NULL data)\n");
+        failures++;
+    }
+    else
+    {
+        printf("FAIL (expected true, got false)\n");
+        failures++;
+    }
 
     /* Load the dummy ROM to trigger SET_MEMORY_MAPS */
     rom = make_dummy_rom(&rom_size);