fix: address Copilot review on PR #126

Three findings from Copilot's review of the leak fix:

1. src/m68000/m68kinterface.c had a redundant `extern struct instr *
   table68k;` -- already declared in readcpu.h.  Removed.
2. m68k_done() reaching directly into table68k (owned by readcpu.c)
   was a brittle cross-module dependency.  Moved the actual free into
   a new free_table68k() in readcpu.c (declared in readcpu.h
   alongside read_table68k).  m68k_done now just calls free_table68k()
   + resets emulation_initialized.  Ownership stays end-to-end inside
   the module that allocates.
3. test/test_hle_bios.c inline comment was too long for one line.
   Converted to a multi-line block above the call.

Build sanity: make -j4 clean, c89-lint passes, dylib still gates 46
retro_* exports.

Co-Authored-By: Claude Opus 4.7 <[email protected]>

Author: JoeMatt

src/m68000/m68kinterface.c

@@ -81,16 +81,14 @@ void M68KDebugResume(void)
 // File-scope so m68k_done() below can reset it after freeing table68k.
 static uint32_t emulation_initialized = 0;
 
-// Free process-lifetime allocations made by read_table68k().  Called
-// from JaguarDone() so ASAN runs see a clean shutdown.
-extern struct instr * table68k;
+// Symmetric counterpart to the lazy init in m68k_pulse_reset().
+// Defers the actual free to readcpu.c::free_table68k() so the table
+// is owned end-to-end by the module that allocates it (table68k is
+// declared in readcpu.h).  Called from JaguarDone() so ASAN sees a
+// clean shutdown.
 void m68k_done(void)
 {
-	if (table68k)
-	{
-		free(table68k);
-		table68k = NULL;
-	}
+	free_table68k();
 	emulation_initialized = 0;
 }
 

src/m68000/readcpu.c

@@ -922,6 +922,20 @@ static void build_insn(int insn)
 }
 
 
+/* Symmetric counterpart to read_table68k: free the opcode table built
+   above.  Idempotent (free(NULL) is a no-op).  Called from
+   m68k_done() in m68kinterface.c so process-lifetime ASAN runs see a
+   clean shutdown. */
+void free_table68k(void)
+{
+	if (table68k)
+	{
+		free(table68k);
+		table68k = NULL;
+	}
+}
+
+
 void read_table68k(void)
 {
 	int i;

src/m68000/readcpu.h

@@ -112,6 +112,7 @@ extern struct instr {
 } *table68k;
 
 extern void read_table68k(void);
+extern void free_table68k(void);
 extern void do_merges(void);
 extern int get_no_mismatches(void);
 extern int nr_cpuop_funcs;

test/test_hle_bios.c

@@ -3172,7 +3172,10 @@ int main(int argc, char *argv[])
 
    printf("\n=== Results: %d passed, %d failed ===\n", passes, fails);
 
-   p_retro_unload_game();   /* matches the second p_retro_load_game above; without this, JaguarDone() never runs and ASAN reports table68k + branch_condition_table as leaks */
+   /* Match the second p_retro_load_game (PAL) call above.  Without
+    * this unload, JaguarDone() never runs for the PAL load and ASAN
+    * reports table68k + branch_condition_table as leaks. */
+   p_retro_unload_game();
    p_retro_deinit();
    dlclose(handle);
    free(dummy_rom);