fix: test_hle_bios + clang-tidy noise from PR #126 first-run

CI on PR #126 (the m68k_done / GPUDone leak fix) surfaced two
issues:

1. ASAN sanitizers job still reported the same 1.5MB + 256B leak
   the PR set out to fix.  Root cause: test/test_hle_bios.c calls
   p_retro_load_game twice (NTSC then PAL) but only calls
   p_retro_unload_game ONCE (between the two loads).  The PAL load
   never gets unloaded -- so JaguarDone() (which now does
   m68k_done() + GPUDone()) is never called for the second load.

   Added the missing p_retro_unload_game() before the final
   p_retro_deinit() at the end of main.

2. clang-tidy fired NEW pre-existing findings on src/core/jaguar.c
   and test/test_hle_bios.c because both are in this PR's diff (the
   workflow runs clang-tidy on changed files, not changed lines):
   - bugprone-incorrect-roundings on USEC_TO_RISC_CYCLES /
     USEC_TO_M68K_CYCLES in src/core/event.h.  Idiom is
     `(double + 0.5)` integer cast; lround() is C99 and we're
     C89/GNU89.
   - bugprone-multi-level-implicit-pointer-conversion on
     test_hle_bios.c's dlsym() patterns.

   Both added to the disabled list in .clang-tidy with
   documented rationale.

Co-Authored-By: Claude Opus 4.7 <[email protected]>

Author: JoeMatt

.clang-tidy

@@ -24,6 +24,8 @@ Checks: >
   -bugprone-suspicious-include,
   -bugprone-switch-missing-default-case,
   -bugprone-branch-clone,
+  -bugprone-incorrect-roundings,
+  -bugprone-multi-level-implicit-pointer-conversion,
   -clang-analyzer-deadcode.DeadStores,
   -clang-analyzer-optin.portability.UnixAPI,
   -clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling,
@@ -49,6 +51,13 @@ FormatStyle: none
 # - suspicious-include: project includes .c files in a couple of dispatch headers.
 # - switch-missing-default-case: cosmetic; switches on bit-field decode patterns
 #   commonly omit default because all valid bit values are handled.
+# - incorrect-roundings: src/core/event.h's USEC_TO_RISC_CYCLES /
+#   USEC_TO_M68K_CYCLES use the (double + 0.5) integer-cast idiom for
+#   cycle conversion.  lround() is C99 (we're C89/GNU89), and the
+#   inputs are non-negative so the idiom is correct here.
+# - multi-level-implicit-pointer-conversion: dlsym() returns void*
+#   that test harnesses cast directly to function pointers / data
+#   pointer-to-pointer; canonical idiom in the libretro dlsym pattern.
 # - branch-clone: register-decode if-chains in src/cd/cdrom.c and src/tom/tom.c
 #   intentionally write the same value for several adjacent register addresses
 #   to make the address->effect mapping legible.  Real bug clones are caught

test/test_hle_bios.c

@@ -3172,6 +3172,7 @@ int main(int argc, char *argv[])
 
    printf("\n=== Results: %d passed, %d failed ===\n", passes, fails);
 
+   p_retro_unload_game();   /* matches the second p_retro_load_game above; without this, JaguarDone() never runs and ASAN reports table68k + branch_condition_table as leaks */
    p_retro_deinit();
    dlclose(handle);
    free(dummy_rom);