Fix greatgun mappings & mouse buttons, add multimouse/lightgun#57
Open
StormedBubbles wants to merge 2 commits intolibretro:masterfrom
Open
Fix greatgun mappings & mouse buttons, add multimouse/lightgun#57StormedBubbles wants to merge 2 commits intolibretro:masterfrom
StormedBubbles wants to merge 2 commits intolibretro:masterfrom
Conversation
Author
|
Is there a plan to merge them? |
Author
|
Hi, I have been using this on my own build (Raspberry Pi 4B) since I submitted the PR. I don't think there are any issues introduced by the additions. I wasn't able to extend the player count past 4 for some reason. Compiling worked, but the emulator would crash without an indication of what the issue was. I'm guessing the issue had something to do with input descriptors because lr-mame had a similar issue that was resolved a while ago. In the future, I can add in additional gun buttons (Aux B, Aux C, Gun Start/Select, Gun D-Pad) if desired. I will leave that for a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This is almost identical to my lr-mame2015 pull request since 2015 and 2016 largely share the same code. Here is what I changed:
The "XY device (Restart)" option replaces the option that enables the mouse and allows the user to switch among "none," "lightgun," and "mouse." As mentioned in my 2015 pull request, it would be better to make this option not require a restart. I wasn't able to figure that out, so please feel free to edit or make suggestions on how this could be done!