Skip to content

Add files via upload#18987

Merged
LibretroAdmin merged 4 commits intolibretro:masterfrom
metallic77:commits
May 1, 2026
Merged

Add files via upload#18987
LibretroAdmin merged 4 commits intolibretro:masterfrom
metallic77:commits

Conversation

@metallic77
Copy link
Copy Markdown
Contributor

Guidelines

  1. Rebase before opening a pull request
  2. If you are sending several unrelated fixes or features, use a branch and a separate pull request for each
  3. If possible try squashing everything in a single commit. This is particularly beneficial in the case of feature merges since it allows easy bisecting when a problem arises
  4. RetroArch codebase follows C89 coding rules for portability across many old platforms check using C89_BUILD=1

Description

[Description of the pull request, detail any issues you are fixing or any features you are implementing]

Related Issues

[Any issues this pull request may be addressing]

Related Pull Requests

[Any other PRs from related repositories that might be needed for this pull request to work]

Reviewers

[If possible @mention all the people that should review your pull request]

Add a border crop soft filter. Useful for some 8bit/16bit computers, like fuse/hatari/caprice32 etc.

@hizzlekizzle
Copy link
Copy Markdown
Collaborator

Can we get the greek(?) comments translated to English?

@metallic77
Copy link
Copy Markdown
Contributor Author

Ok did that

compiles and runs perfectly fine on linux Mint.
@metallic77
Copy link
Copy Markdown
Contributor Author

Check the changes, also added EMMIR NTSC generic "crt" variant.

@metallic77
Copy link
Copy Markdown
Contributor Author

emmir

@metallic77
Copy link
Copy Markdown
Contributor Author

To review, as flickers horizontally in some emulators and vertically in others.

@metallic77 metallic77 closed this Apr 29, 2026
@metallic77 metallic77 reopened this May 1, 2026
@LibretroAdmin LibretroAdmin merged commit 181b550 into libretro:master May 1, 2026
86 checks passed
@LibretroAdmin
Copy link
Copy Markdown
Contributor

I will have to fold ntsc_crt_filter all into one file if I'm going to be able to successfully add this to the Makefile and the Griffin unity-like build system

@metallic77
Copy link
Copy Markdown
Contributor Author

I wonder if the filter is assuming it will accept a 320x480 image, as it picks 2 fields and flickers between them. E.g. if you run it on 240p it will essentially halve the resolution, dramatically deteriorating the image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants