Vulkan: Fix HDR pipeline init to revert back to sdr_render_pass#18680
Merged
LibretroAdmin merged 1 commit intolibretro:masterfrom Feb 4, 2026
Merged
Conversation
Fix indentation of the HDR pipeline initialization block inside vulkan_init_pipelines to use consistent 3-space indentation matching the surrounding code style. Use vk->sdr_render_pass instead of vk->render_pass when restoring pipeline state after the HDR tonemapping readback pipeline setup, to correctly reference the SDR render pass.
MajorPainTheCactus
changed the title
MajorPainTheCactus
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vk->render_passtovk->sdr_render_passwhen restoring pipeline state after the HDR tonemapping readback pipeline setup, to correctly reference the SDR render passBig thanks to @warmenhoven who found this fix and did the work in tracking it down!