Separate quit/close/reset confirmation options#18640
Merged
LibretroAdmin merged 1 commit intolibretro:masterfrom Jan 24, 2026
Merged
Separate quit/close/reset confirmation options#18640LibretroAdmin merged 1 commit intolibretro:masterfrom
LibretroAdmin merged 1 commit intolibretro:masterfrom
Conversation
Collaborator
|
I think only migrating the old key value to the new quit confirmation is fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Due to popular demand let's separate the joined hotkey confirmation option. Each defaults to true.
Also renamed
quit_press_twicetoconfirm_quit(becauseclose_press_twiceandreset_press_twicewould look messy in the config file) and migrated the old key value to the new one (only to quit confirmation, or should it transfer to all?), and made sure it does not get written back to new config on save. And also minor cleanups to hotkey trigger logic.