Skip to content

replace ifdef from "LAKKA" to "HAVE_LAKKA" in command.h#18638

Merged
sonninnos merged 1 commit intolibretro:masterfrom
ShigeakiAsai:replace-ifdef-from-LAKKA-to-HAVE_LAKKA
Jan 23, 2026
Merged

replace ifdef from "LAKKA" to "HAVE_LAKKA" in command.h#18638
sonninnos merged 1 commit intolibretro:masterfrom
ShigeakiAsai:replace-ifdef-from-LAKKA-to-HAVE_LAKKA

Conversation

@ShigeakiAsai
Copy link
Copy Markdown
Contributor

Description

In Lakka devel branch - retroarch building, the following compilation error was occurred.

input/input_driver.c: In function 'input_driver_init_command':
input/input_driver.c:5154:33: error: implicit declaration of function 'command_uds_new'; did you mean 'command_stdin_new'? [-Wimplicit-function-declaration]
 5154 |    if (!(input_st->command[2] = command_uds_new()))
      |                                 ^~~~~~~~~~~~~~~
      |                                 command_stdin_new
input/input_driver.c:5154:31: error: assignment to 'command_t *' {aka 'struct command_handler *'} from 'int' makes pointer from integer without a cast [-Wint-conversion]
 5154 |    if (!(input_st->command[2] = command_uds_new()))
      |                               ^

#ifdef LAKKA

In command.h, it uses #ifdef LAKKA, but Lakka build expects #ifdef HAVE_LAKKA.

Related Issues

None

Related Pull Requests

retroarch: fix miss ifdef from LAKKA to HAVE_LAKKA #2166

Thanks
ASAI, Shigeaki

@sonninnos sonninnos merged commit 0c987f8 into libretro:master Jan 23, 2026
34 checks passed
@ShigeakiAsai ShigeakiAsai deleted the replace-ifdef-from-LAKKA-to-HAVE_LAKKA branch January 23, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants