Skip to content

fix: null pointer on command_get_status fonction #18585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LibretroAdmin merged 1 commit into from
Jan 6, 2026
Merged

fix: null pointer on command_get_status fonction #18585

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 43 additions & 11 deletions command.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1035,39 +1035,71 @@ bool command_get_status(command_t *cmd, const char* arg)
{
size_t _len;
char reply[4096];
uint8_t flags = content_get_flags();
uint8_t flags;

if (!cmd)
return false;

if (!cmd->replier)
return false;

flags = content_get_flags();

if (flags & CONTENT_ST_FLAG_IS_INITED)
{
/* add some content info */
core_info_t *core_info = NULL;
runloop_state_t *runloop_st = runloop_state_get_ptr();
const char *basename_path = NULL;

if (!runloop_st)
{
_len = strlcpy(reply, "GET_STATUS ERROR", sizeof(reply));
cmd->replier(cmd, reply, _len);
return false;
}

core_info_get_current_core(&core_info);

_len = strlcpy(reply, "GET_STATUS ", sizeof(reply));
_len = strlcpy(reply, "GET_STATUS ", sizeof(reply));

if (runloop_st->flags & RUNLOOP_FLAG_PAUSED)
_len += strlcpy(reply + _len, "PAUSED", sizeof(reply) - _len);
else
_len += strlcpy(reply + _len, "PLAYING", sizeof(reply) - _len);
_len += strlcpy(reply + _len, " ", sizeof(reply) - _len);
if (core_info)

_len += strlcpy(reply + _len, " ", sizeof(reply) - _len);

if (core_info && core_info->system_id)
_len += strlcpy(reply + _len, core_info->system_id,
sizeof(reply) - _len);
else
else if (runloop_st->system.info.library_name)
_len += strlcpy(reply + _len, runloop_st->system.info.library_name,
sizeof(reply) - _len);
_len += strlcpy(reply + _len, ",", sizeof(reply) - _len);
_len += strlcpy(reply + _len,
path_basename(path_get(RARCH_PATH_BASENAME)), sizeof(reply) - _len);
_len += snprintf(reply + _len, sizeof(reply) - _len,
else
_len += strlcpy(reply + _len, "UNKNOWN", sizeof(reply) - _len);

_len += strlcpy(reply + _len, ",", sizeof(reply) - _len);

basename_path = path_get(RARCH_PATH_BASENAME);
if (basename_path)
{
const char *basename = path_basename(basename_path);
if (basename)
_len += strlcpy(reply + _len, basename, sizeof(reply) - _len);
else
_len += strlcpy(reply + _len, "UNKNOWN", sizeof(reply) - _len);
}
else
_len += strlcpy(reply + _len, "UNKNOWN", sizeof(reply) - _len);

_len += snprintf(reply + _len, sizeof(reply) - _len,
",crc32=%lx\n", (unsigned long)content_get_crc());
}
else
_len = strlcpy(reply, "GET_STATUS CONTENTLESS", sizeof(reply));
_len = strlcpy(reply, "GET_STATUS CONTENTLESS", sizeof(reply));

cmd->replier(cmd, reply, _len);

return true;
}

Expand Down
Loading