Emscripten bugfixes/nits#18562
Merged
LibretroAdmin merged 1 commit intolibretro:masterfrom Jan 1, 2026
Merged
Conversation
Contributor
|
Thanks for doing the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apologies for the large PR (again...)
This fixes a number of minor bugs I found in the emscripten build, and there's a few tiny changes that aren't necessarily bugfixes.
Change list:
HAVE_STB_VORBISdefinecommand_set_shadernow sets thevideo_shader_enablesetting correspondingly.glFinishexplicitly in PROXY_TO_PTHREAD builds - without this, Firefox (at least on windows) would have a terrible GPU desync and was unusable in any menu driver except RGUI.modern_pipeline_xmb_ribbon.glsl.vert.hwas out of date compared to the legacy shader and wasn't displaying the ribbon.HAVE_RUNAHEADby default - it was also missing from Makefile.emscriptenemscripten/pre.jstoemscripten/extern_pre.jsfor consistency.Module.onRuntimeInitialized- waiting for the javascript module to load is a better and potentially less buggy alternative.Some thoughts:
emscripten_mainloopdefinition back toplatform_emscripten.c?Happy new year all!
CC @JoeOsborn
P.S. @LibretroAdmin - I think now with the aforementioned Firefox bug fixed, the new web player is 100% ready. How should we proceed? Should I make an issue for tracking?