Prevent uninitialized memory when searching for serial in database.#18320
Merged
LibretroAdmin merged 1 commit intolibretro:masterfrom Oct 20, 2025
Merged
Prevent uninitialized memory when searching for serial in database.#18320LibretroAdmin merged 1 commit intolibretro:masterfrom
LibretroAdmin merged 1 commit intolibretro:masterfrom
Conversation
Collaborator
|
Why not just clear the var always without the if before the for loop? |
Contributor
Author
|
Sure, why not. |
zoltanvb
force-pushed
the
empty_serial_fix
branch
from
2d8372a to
4464912
Compare
sonninnos
reviewed
Oct 18, 2025
zoltanvb
force-pushed
the
empty_serial_fix
branch
from
4464912 to
b9fdcc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When serial can not be retrieved from the image (length is 0), the translation for the database search syntax may return uninitialized memory, resulting in bogus database hits (which are not written to playlist), but also in endless scanning.
Scanning one such image was failing (running endlessly) at least once in ten tries, with the modification, the endless scan can not be reproduced any more.
Related Issues
Closes #16906 (most probably). Maybe also #10876 , as the trace also points to serial scanning.