Don't clear default core info on missing list#18269
Merged
LibretroAdmin merged 1 commit intolibretro:masterfrom Sep 18, 2025
Merged
Don't clear default core info on missing list#18269LibretroAdmin merged 1 commit intolibretro:masterfrom
LibretroAdmin merged 1 commit intolibretro:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an edge-case bug that I noticed in #18174. The bug seems only possible in emscripten since the core files currently don't contain the core itself (so they don't have to exist).
When the frontend knows the core extension (with
frontend_driver_get_core_extension) but the core file is missing, savestate support was disabled due tocore_info_list_get_infoclearing the default core info (as set bycore_info_init_current_core) without checking if the new info was valid. Effectively it set thesavestate_support_levelback toCORE_INFO_SAVESTATE_DISABLEDwhen the default should beCORE_INFO_SAVESTATE_DETERMINISTIC.