wayland: Don't try to guess the display size#18265
Closed
ColinKinloch wants to merge 1 commit intolibretro:masterfrom
Closed
wayland: Don't try to guess the display size#18265ColinKinloch wants to merge 1 commit intolibretro:masterfrom
ColinKinloch wants to merge 1 commit intolibretro:masterfrom
Conversation
Contributor
|
Where are we with this PR? |
Contributor
Author
|
I'm in the process of a large refactor of the wayland code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On wayland the display the surface will be mapped to is not known in advance. I think it's more correct to not try to guess in case it triggers large unnecessary allocations.
Currently the splash screen means that this value is correctly set, however the issue the splash screen was working around will be fixed in mutter 49.
I've marked this as draft as I'm not sure if leaving the width and height values unchanged is correct per the RetroArch API.