Add activity state detection to prevent parameter conflicts when resuming from home screen after external game launch#18231
Merged
LibretroAdmin merged 2 commits intolibretro:masterfrom Sep 3, 2025
Conversation
…suming from home screen
Collaborator
|
the CI build failures are unrelated to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After launching a game from a launcher like Daijishou or Beacon using FLAG_ACTIVITY_CLEAR_TOP, RetroArch would crash if resume was attempted from a home screen launch due to parameter conflicts. This fix adds activity state detection to prevent these parameter conflicts by bringing RetroArch to the front without passing any parameters if RetroActivityFuture is already running (indicating a game was launched externally). This also simplifies the content detection logic in OnNewIntent introduced in #18210.
Related Pull Requests
#18210 - Add onNewIntent handler to support game launch with FLAG_ACTIVITY_CLEAR_TOP