Skip to content

Do not skip over frame backrefs for version-1 and older movies #18220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sonninnos merged 1 commit into from
Aug 30, 2025
Merged

Do not skip over frame backrefs for version-1 and older movies #18220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions input/bsv/bsvmovie.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,7 +536,8 @@ bool bsv_movie_read_next_events(bsv_movie_t *handle, bool skip_checkpoints)
{
input_driver_state_t *input_st = input_state_get_ptr();
/* Skip over backref */
intfstream_seek(handle->file, sizeof(uint32_t), SEEK_CUR);
if (handle->version > 1)
intfstream_seek(handle->file, sizeof(uint32_t), SEEK_CUR);
/* Start by reading key event */
if (intfstream_read(handle->file, &(handle->key_event_count), 1) == 1)
{
Expand Down Expand Up @@ -831,8 +832,11 @@ bool replay_check_same_timeline(bsv_movie_t *movie, uint8_t *other_movie, int64_
goto exit;
}
/* skip past backref */
intfstream_seek(movie->file, 4, SEEK_CUR);
intfstream_seek(check_stream, 4, SEEK_CUR);
if (movie->version > 1)
{
intfstream_seek(movie->file, sizeof(uint32_t), SEEK_CUR);
intfstream_seek(check_stream, sizeof(uint32_t), SEEK_CUR);
}
if (intfstream_read(movie->file, &keycount1, 1) < 1 ||
intfstream_read(check_stream, &keycount2, 1) < 1 ||
keycount1 != keycount2)
Expand Down
Loading