Cleanups

Author: LibretroAdmin

gfx/common/dbus_common.c

@@ -30,7 +30,6 @@ void dbus_ensure_connection(void)
 {
 #ifdef HAVE_DBUS
     DBusError err;
-    int ret;
 
     dbus_error_init(&err);
 

gfx/common/wayland_common.c

@@ -520,7 +520,7 @@ static shm_buffer_t *create_shm_buffer(gfx_ctx_wayland_data_t *wl, int width,
    int height,
    uint32_t format)
 {
-   int fd, ofd;
+   int fd;
    struct wl_shm_pool *pool = NULL;
    void *data               = NULL;
    shm_buffer_t *buffer     = NULL;

gfx/display_servers/dispserv_kms.c

@@ -126,7 +126,6 @@ static void *kms_display_server_get_resolution_list(
    bool curr_interlaced              = false;
    bool curr_dblscan                 = false;
    float curr_refreshrate            = 0;
-   unsigned curr_orientation         = 0;
    struct video_display_config *conf = NULL;
 
 

gfx/display_servers/dispserv_win32.c

@@ -302,40 +302,41 @@ static bool win32_display_server_set_window_opacity(
 static bool win32_display_server_set_window_progress(
       void *data, int progress, bool finished)
 {
-   uint8_t win32_flags     = 0;
-   HWND hwnd               = win32_get_window();
    dispserv_win32_t *serv  = (dispserv_win32_t*)data;
 
    if (!serv)
       return false;
 
 #ifdef HAS_TASKBAR_EXT
-   win32_flags             = win32_get_flags();
-
-   if (!serv->taskbar_list || !(win32_flags & WIN32_CMN_FLAG_TASKBAR_CREATED))
-      return false;
-
-   if (progress == -1)
-   {
-      if (ITaskbarList3_SetProgressState(
-               serv->taskbar_list, hwnd, TBPF_INDETERMINATE) != S_OK)
-         return false;
-   }
-   else if (finished)
-   {
-      if (ITaskbarList3_SetProgressState(
-               serv->taskbar_list, hwnd, TBPF_NOPROGRESS) != S_OK)
-         return false;
-   }
-   else if (progress >= 0)
    {
-      if (ITaskbarList3_SetProgressState(
-               serv->taskbar_list, hwnd, TBPF_NORMAL) != S_OK)
-         return false;
+      uint8_t win32_flags  = win32_get_flags();
+      HWND hwnd            = win32_get_window();
 
-      if (ITaskbarList3_SetProgressValue(
-               serv->taskbar_list, hwnd, progress, 100) != S_OK)
+      if (!serv->taskbar_list || !(win32_flags & WIN32_CMN_FLAG_TASKBAR_CREATED))
          return false;
+
+      if (progress == -1)
+      {
+         if (ITaskbarList3_SetProgressState(
+                  serv->taskbar_list, hwnd, TBPF_INDETERMINATE) != S_OK)
+            return false;
+      }
+      else if (finished)
+      {
+         if (ITaskbarList3_SetProgressState(
+                  serv->taskbar_list, hwnd, TBPF_NOPROGRESS) != S_OK)
+            return false;
+      }
+      else if (progress >= 0)
+      {
+         if (ITaskbarList3_SetProgressState(
+                  serv->taskbar_list, hwnd, TBPF_NORMAL) != S_OK)
+            return false;
+
+         if (ITaskbarList3_SetProgressValue(
+                  serv->taskbar_list, hwnd, progress, 100) != S_OK)
+            return false;
+      }
    }
 #endif
 

gfx/drivers/d3d8.c

@@ -409,9 +409,6 @@ static void d3d8_set_vertices(
       unsigned pass,
       unsigned vert_width, unsigned vert_height, uint64_t frame_count)
 {
-   unsigned width  = d3d->vp.full_width;
-   unsigned height = d3d->vp.full_height;
-
    if (chain->last_width != vert_width || chain->last_height != vert_height)
    {
       Vertex vert[4];
@@ -2239,9 +2236,7 @@ static void d3d8_set_viewport(void *data,
 static bool d3d8_initialize(d3d8_video_t *d3d, const video_info_t *info)
 {
    struct LinkInfo link_info;
-   unsigned i           = 0;
    bool ret             = true;
-   settings_t *settings = config_get_ptr();
 
    if (!d3d)
       return false;

gfx/drivers/fpga_gfx.c

@@ -135,6 +135,9 @@ static void *fpga_init(const video_info_t *video,
 {
    fpga_t *fpga                         = (fpga_t*)calloc(1, sizeof(*fpga));
 
+   if (!fpga)
+      return NULL;
+
    *input                               = NULL;
    *input_data                          = NULL;
 
@@ -152,11 +155,6 @@ static void *fpga_init(const video_info_t *video,
    fpga_create(fpga);
 
    return fpga;
-
-error:
-   if (fpga)
-      free(fpga);
-   return NULL;
 }
 
 static bool fpga_frame(void *data, const void *frame,

gfx/drivers/oga_gfx.c

@@ -103,7 +103,7 @@ typedef struct oga_video
 
 static bool oga_create_display(oga_video_t* vid)
 {
-   int i, ret;
+   int i;
    drmModeConnector *connector;
    drmModeModeInfo *mode;
    drmModeEncoder *encoder;