Skip to content

Commit 1ca8233

Browse files
committed
[PATCH] (file_path_special) Remove 33 unused FILE_PATH_* macros
These macros were defined but had no consumer anywhere in the in-scope tree (verified after excluding deps/, libretro-common/, libretro-db/, tests-other/, samples/, and vendored SDK trees). The list: Extension constants for image/audio formats RetroArch reads through generic file APIs rather than format-specific paths: FILE_PATH_MP3_EXTENSION, FILE_PATH_FLAC_EXTENSION, FILE_PATH_OGG_EXTENSION, FILE_PATH_WAV_EXTENSION, FILE_PATH_MOD_EXTENSION, FILE_PATH_S3M_EXTENSION, FILE_PATH_XM_EXTENSION, FILE_PATH_JPEG_EXTENSION, FILE_PATH_BMP_EXTENSION, FILE_PATH_TGA_EXTENSION, FILE_PATH_JPG_EXTENSION Patch-format extensions handled generically by the patch loader: FILE_PATH_UPS_EXTENSION, FILE_PATH_IPS_EXTENSION, FILE_PATH_BPS_EXTENSION, FILE_PATH_XDELTA_EXTENSION Archive extensions handled by libretro-common's archive_file: FILE_PATH_ZIP_EXTENSION, FILE_PATH_7Z_EXTENSION Shader-preset extensions; the consumer in gfx/video_shader_parse.c:video_shader_get_preset_extension uses bare string literals rather than these macros: FILE_PATH_CGP_EXTENSION, FILE_PATH_GLSLP_EXTENSION, FILE_PATH_SLANGP_EXTENSION Other dead extension constants: FILE_PATH_AUTO_EXTENSION, FILE_PATH_OPT_EXTENSION, FILE_PATH_RTC_EXTENSION, FILE_PATH_LPL_EXTENSION_NO_DOT, FILE_PATH_RDB_EXTENSION_NO_DOT, FILE_PATH_EVENT_LOG_EXTENSION, FILE_PATH_LOCK_EXTENSION, FILE_PATH_STANDALONE_EXEMPT_EXTENSION Dead URL/playlist constants: FILE_PATH_INDEX_EXTENDED_URL, FILE_PATH_NETPLAY_ROOM_LIST_URL, FILE_PATH_RETROACHIEVEMENTS_URL, FILE_PATH_LUTRO_PLAYLIST, FILE_PATH_NUL The header file_path_special.h is internal (not exposed via libretro.h) and is included only by RetroArch's own .c files; removing these macros is safe within the tree. The bare string literals these macros would have parameterised continue to work as before.
1 parent 2619e44 commit 1ca8233

1 file changed

Lines changed: 0 additions & 33 deletions

File tree

file_path_special.h

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -31,52 +31,22 @@ RETRO_BEGIN_DECLS
3131
#define FILE_PATH_CONTENT_BASENAME "content.png"
3232
#define FILE_PATH_BUILTIN "builtin"
3333
#define FILE_PATH_DETECT "DETECT"
34-
#define FILE_PATH_LUTRO_PLAYLIST "Lutro.lpl"
35-
#define FILE_PATH_NUL "nul"
36-
#define FILE_PATH_CGP_EXTENSION ".cgp"
37-
#define FILE_PATH_GLSLP_EXTENSION ".glslp"
38-
#define FILE_PATH_SLANGP_EXTENSION ".slangp"
39-
#define FILE_PATH_AUTO_EXTENSION ".auto"
4034
#define FILE_PATH_BSV_EXTENSION ".replay"
41-
#define FILE_PATH_OPT_EXTENSION ".opt"
4235
#ifdef DJGPP
4336
#define FILE_PATH_CORE_INFO_EXTENSION ".inf"
4437
#else
4538
#define FILE_PATH_CORE_INFO_EXTENSION ".info"
4639
#endif
4740
#define FILE_PATH_CONFIG_EXTENSION ".cfg"
4841
#define FILE_PATH_REMAP_EXTENSION ".rmp"
49-
#define FILE_PATH_RTC_EXTENSION ".rtc"
5042
#define FILE_PATH_CHT_EXTENSION ".cht"
5143
#define FILE_PATH_SRM_EXTENSION ".srm"
5244
#define FILE_PATH_STATE_EXTENSION ".state"
5345
#define FILE_PATH_LPL_EXTENSION ".lpl"
54-
#define FILE_PATH_LPL_EXTENSION_NO_DOT "lpl"
5546
#define FILE_PATH_PNG_EXTENSION ".png"
56-
#define FILE_PATH_MP3_EXTENSION ".mp3"
57-
#define FILE_PATH_FLAC_EXTENSION ".flac"
58-
#define FILE_PATH_OGG_EXTENSION ".ogg"
59-
#define FILE_PATH_WAV_EXTENSION ".wav"
60-
#define FILE_PATH_MOD_EXTENSION ".mod"
61-
#define FILE_PATH_S3M_EXTENSION ".s3m"
62-
#define FILE_PATH_XM_EXTENSION ".xm"
63-
#define FILE_PATH_JPEG_EXTENSION ".jpeg"
64-
#define FILE_PATH_BMP_EXTENSION ".bmp"
65-
#define FILE_PATH_TGA_EXTENSION ".tga"
66-
#define FILE_PATH_JPG_EXTENSION ".jpg"
67-
#define FILE_PATH_UPS_EXTENSION ".ups"
68-
#define FILE_PATH_IPS_EXTENSION ".ips"
69-
#define FILE_PATH_BPS_EXTENSION ".bps"
70-
#define FILE_PATH_XDELTA_EXTENSION ".xdelta"
7147
#define FILE_PATH_RDB_EXTENSION ".rdb"
72-
#define FILE_PATH_RDB_EXTENSION_NO_DOT "rdb"
73-
#define FILE_PATH_ZIP_EXTENSION ".zip"
74-
#define FILE_PATH_7Z_EXTENSION ".7z"
7548
#define FILE_PATH_INDEX_URL ".index"
7649
#define FILE_PATH_INDEX_DIRS_URL ".index-dirs"
77-
#define FILE_PATH_INDEX_EXTENDED_URL ".index-extended"
78-
#define FILE_PATH_NETPLAY_ROOM_LIST_URL "registry.lpl"
79-
#define FILE_PATH_RETROACHIEVEMENTS_URL "http://i.retroachievements.org"
8050
#define FILE_PATH_LOBBY_LIBRETRO_URL "http://lobby.libretro.com/"
8151
#define FILE_PATH_CORE_THUMBNAILS_URL "http://thumbnails.libretro.com"
8252
#define FILE_PATH_CORE_THUMBNAILPACKS_URL "http://thumbnailpacks.libretro.com"
@@ -110,13 +80,10 @@ RETRO_BEGIN_DECLS
11080
#else
11181
#define FILE_PATH_DEFAULT_EVENT_LOG "retroarch.log"
11282
#endif
113-
#define FILE_PATH_EVENT_LOG_EXTENSION ".log"
11483
#define FILE_PATH_DISK_CONTROL_INDEX_EXTENSION ".ldci"
11584
#define FILE_PATH_CORE_BACKUP_EXTENSION ".lcbk"
11685
#define FILE_PATH_CORE_BACKUP_EXTENSION_NO_DOT "lcbk"
117-
#define FILE_PATH_LOCK_EXTENSION ".lck"
11886
#define FILE_PATH_LOCK_EXTENSION_NO_DOT "lck"
119-
#define FILE_PATH_STANDALONE_EXEMPT_EXTENSION ".lsae"
12087
#define FILE_PATH_STANDALONE_EXEMPT_EXTENSION_NO_DOT "lsae"
12188
#define FILE_PATH_BACKUP_EXTENSION ".bak"
12289
#if defined(RARCH_MOBILE)

0 commit comments

Comments
 (0)