refactor test outcome (#262)

Signed-off-by: turuslan <[email protected]>

Author: turuslan

cmake/Hunter/init.cmake

@@ -31,7 +31,7 @@ set(
 include(${CMAKE_CURRENT_LIST_DIR}/HunterGate.cmake)
 
 HunterGate(
-    URL  https://github.com/qdrvm/hunter/archive/refs/tags/v0.25.3-qdrvm15.zip
-    SHA1 b338eb3b6a989f19257d6d4acbc9f810abcf1b32
+    URL  https://github.com/qdrvm/hunter/archive/refs/tags/v0.25.3-qdrvm21.zip
+    SHA1 5b52ab9a309771f172ca609a46e26dde60a8edd7
     LOCAL
 )

src/basic/message_read_writer_error.cpp

@@ -4,7 +4,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-#include "libp2p/basic/message_read_writer_error.hpp"
+#include <libp2p/basic/message_read_writer_error.hpp>
 
 OUTCOME_CPP_DEFINE_CATEGORY(libp2p::basic, MessageReadWriterError, e) {
   using E = libp2p::basic::MessageReadWriterError;

src/basic/varint_reader.cpp

@@ -4,7 +4,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-#include "libp2p/basic/varint_reader.hpp"
+#include <libp2p/basic/varint_reader.hpp>
 
 #include <vector>
 

src/crypto/ecdsa_provider/ecdsa_provider_impl.cpp

@@ -4,16 +4,16 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-#include "libp2p/crypto/ecdsa_provider/ecdsa_provider_impl.hpp"
+#include <libp2p/crypto/ecdsa_provider/ecdsa_provider_impl.hpp>
 
 #include <openssl/err.h>
 #include <openssl/obj_mac.h>
 #include <openssl/x509.h>
 #include <libp2p/common/final_action.hpp>
+#include <libp2p/crypto/common_functions.hpp>
+#include <libp2p/crypto/error.hpp>
+#include <libp2p/crypto/sha/sha256.hpp>
 #include <span>
-#include "libp2p/crypto/common_functions.hpp"
-#include "libp2p/crypto/error.hpp"
-#include "libp2p/crypto/sha/sha256.hpp"
 
 using libp2p::common::FinalAction;
 

src/peer/impl/identity_manager_impl.cpp

@@ -6,7 +6,7 @@
 
 #include <libp2p/peer/impl/identity_manager_impl.hpp>
 
-#include "libp2p/crypto/key_marshaller.hpp"
+#include <libp2p/crypto/key_marshaller.hpp>
 
 namespace libp2p::peer {
 

src/protocol/gossip/impl/message_builder.cpp

@@ -92,7 +92,7 @@ namespace libp2p::protocol::gossip {
         pb_msg_->SerializeToArray(buffer->data() + prefix_sz, msg_sz);
 
     if (control_not_empty_) {
-      pb_msg_->release_control();
+      std::ignore = pb_msg_->release_control();
     }
 
     static constexpr size_t kSizeThreshold = 8192;

src/protocol/identify/identify_msg_processor.cpp

@@ -4,7 +4,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-#include "libp2p/protocol/identify/identify_msg_processor.hpp"
+#include <libp2p/protocol/identify/identify_msg_processor.hpp>
 
 #include <tuple>
 

src/protocol/identify/identify_push.cpp

@@ -4,7 +4,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-#include "libp2p/protocol/identify/identify_push.hpp"
+#include <libp2p/protocol/identify/identify_push.hpp>
 
 #include <string>
 

src/security/plaintext/plaintext_connection.cpp

@@ -7,7 +7,7 @@
 #include <libp2p/security/plaintext/plaintext_connection.hpp>
 
 #include <boost/assert.hpp>
-#include "libp2p/crypto/protobuf/protobuf_key.hpp"
+#include <libp2p/crypto/protobuf/protobuf_key.hpp>
 
 namespace libp2p::connection {
 

test/acceptance/p2p/host/basic_host_test.cpp

@@ -4,9 +4,9 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-#include <libp2p/host/basic_host/basic_host.hpp>
-
 #include <gtest/gtest.h>
+#include <libp2p/host/basic_host/basic_host.hpp>
+#include <qtils/test/outcome.hpp>
 
 #include "mock/libp2p/connection/stream_mock.hpp"
 #include "mock/libp2p/network/dialer_mock.hpp"
@@ -19,7 +19,6 @@
 
 #include <libp2p/common/literals.hpp>
 #include "testutil/gmock_actions.hpp"
-#include "testutil/outcome.hpp"
 
 using namespace libp2p;
 using namespace common;
@@ -160,7 +159,7 @@ TEST_F(BasicHostTest, NewStream) {
 
   bool executed = false;
   host->newStream(pinfo, {protocol}, [&](auto &&result) {
-    EXPECT_OUTCOME_TRUE(stream, result);
+    auto stream = EXPECT_OK(result);
     (void)stream;
     executed = true;
   });