Remove noexcept from p2p (#260)

Signed-off-by: Igor Egorov <[email protected]>

Author: Igor Egorov

include/libp2p/basic/scheduler.hpp

@@ -40,7 +40,7 @@ namespace libp2p::basic {
      * Defers callback to be executed during the next IO loop cycle
      * @param cb callback
      */
-    void schedule(Callback &&cb) noexcept {
+    void schedule(Callback &&cb) {
       std::ignore = scheduleImpl(std::move(cb), Time::zero(), false);
     }
 
@@ -49,8 +49,7 @@ namespace libp2p::basic {
      * @param cb callback
      * @param delay_from_now time interval
      */
-    void schedule(Callback &&cb,
-                  std::chrono::milliseconds delay_from_now) noexcept {
+    void schedule(Callback &&cb, std::chrono::milliseconds delay_from_now) {
       std::ignore = scheduleImpl(std::move(cb), delay_from_now, false);
     }
 
@@ -60,7 +59,7 @@ namespace libp2p::basic {
      * @return handle which can be used for cancelling, rescheduling, and scoped
      * lifetime
      */
-    [[nodiscard]] Handle scheduleWithHandle(Callback &&cb) noexcept {
+    [[nodiscard]] Handle scheduleWithHandle(Callback &&cb) {
       return scheduleImpl(std::move(cb), Time::zero(), true);
     }
 
@@ -72,15 +71,15 @@ namespace libp2p::basic {
      * lifetime
      */
     [[nodiscard]] Handle scheduleWithHandle(
-        Callback &&cb, std::chrono::milliseconds delay_from_now) noexcept {
+        Callback &&cb, std::chrono::milliseconds delay_from_now) {
       return scheduleImpl(std::move(cb), delay_from_now, true);
     }
 
     /**
      * Backend's async
      * @return milliseconds since async's epoch
      */
-    virtual std::chrono::milliseconds now() const noexcept = 0;
+    virtual std::chrono::milliseconds now() const = 0;
 
     /**
      * Doesn't allow lvalue callbacks
@@ -99,6 +98,6 @@ namespace libp2p::basic {
      */
     virtual Handle scheduleImpl(Callback &&cb,
                                 std::chrono::milliseconds delay_from_now,
-                                bool make_handle) noexcept = 0;
+                                bool make_handle) = 0;
   };
 }  // namespace libp2p::basic

include/libp2p/basic/scheduler/asio_scheduler_backend.hpp

@@ -32,7 +32,7 @@ namespace libp2p::basic {
     /**
      * @return Milliseconds since steady clock's epoch
      */
-    std::chrono::milliseconds now() const noexcept override;
+    std::chrono::milliseconds now() const override;
 
     /**
      * Sets the timer. Called by Scheduler implementation

include/libp2p/basic/scheduler/backend.hpp

@@ -21,7 +21,7 @@ namespace libp2p::basic {
     /**
      * Called from backend to fire callbacks
      */
-    virtual void pulse() noexcept = 0;
+    virtual void pulse() = 0;
   };
 
   /**
@@ -44,7 +44,7 @@ namespace libp2p::basic {
      * Current async
      * @return Milliseconds elapsed from async's epoch
      */
-    virtual std::chrono::milliseconds now() const noexcept = 0;
+    virtual std::chrono::milliseconds now() const = 0;
 
     /**
      * Implementation-defined defer or delay function.

include/libp2p/basic/scheduler/manual_scheduler_backend.hpp

@@ -28,7 +28,7 @@ namespace libp2p::basic {
     /**
      * @return Milliseconds since clock's epoch. Clock is set manually
      */
-    std::chrono::milliseconds now() const noexcept override {
+    std::chrono::milliseconds now() const override {
       return current_clock_;
     }
 

include/libp2p/basic/scheduler/scheduler_impl.hpp

@@ -28,15 +28,15 @@ namespace libp2p::basic {
                   Scheduler::Config config);
 
     /// Returns current async
-    std::chrono::milliseconds now() const noexcept override;
+    std::chrono::milliseconds now() const override;
 
     /// Scheduler API impl
     Handle scheduleImpl(Callback &&cb,
                         std::chrono::milliseconds delay_from_now,
-                        bool make_handle) noexcept override;
+                        bool make_handle) override;
 
     /// Timer callback, called from SchedulerBackend
-    void pulse() noexcept override;
+    void pulse() override;
 
    private:
     size_t callReady(Time now);

include/libp2p/connection/layer_connection.hpp

@@ -30,7 +30,7 @@ namespace libp2p::connection {
 
     /// returns if this side is an initiator of this connection, or false if it
     /// was a server in that case
-    virtual bool isInitiator() const noexcept = 0;
+    virtual bool isInitiator() const = 0;
 
     /**
      * @brief Get local multiaddress for this connection.

include/libp2p/event/bus.hpp

@@ -64,7 +64,7 @@ namespace libp2p::event {
      * Explicitly unsubscribe from channel before the lifetime
      * of this object expires
      */
-    void unsubscribe() noexcept {
+    void unsubscribe() {
       if (handle_.connected()) {
         try {
           handle_.disconnect();
@@ -78,7 +78,7 @@ namespace libp2p::event {
     Handle() = default;
 
     /// Cancels existing connection
-    Handle &operator=(Handle &&rhs) noexcept {
+    Handle &operator=(Handle &&rhs) {
       unsubscribe();
       handle_ = std::move(rhs.handle_);
 

include/libp2p/layer/websocket/ssl_connection.hpp

@@ -25,7 +25,7 @@ namespace libp2p::connection {
                   std::shared_ptr<LayerConnection> connection,
                   std::shared_ptr<boost::asio::ssl::context> ssl_context);
 
-    bool isInitiator() const noexcept override;
+    bool isInitiator() const override;
     outcome::result<multi::Multiaddress> localMultiaddr() override;
     outcome::result<multi::Multiaddress> remoteMultiaddr() override;
 

include/libp2p/layer/websocket/ws_connection.hpp

@@ -55,7 +55,7 @@ namespace libp2p::connection {
                           std::shared_ptr<LayerConnection> connection,
                           std::shared_ptr<basic::Scheduler> scheduler);
 
-    bool isInitiator() const noexcept override;
+    bool isInitiator() const override;
 
     void start();
     void stop();

include/libp2p/multi/multihash.hpp

@@ -23,8 +23,8 @@ namespace libp2p::multi {
    public:
     Multihash(const Multihash &other) = default;
     Multihash &operator=(const Multihash &other) = default;
-    Multihash(Multihash &&other) noexcept = default;
-    Multihash &operator=(Multihash &&other) noexcept = default;
+    Multihash(Multihash &&other) = default;
+    Multihash &operator=(Multihash &&other) = default;
     ~Multihash() = default;
 
     using Buffer = Bytes;