Fix output of transpose after "guys" -> "folks" change#54
Closed
ftsimas wants to merge 2 commits intolearnyouahaskell:mainfrom
Closed
Fix output of transpose after "guys" -> "folks" change#54ftsimas wants to merge 2 commits intolearnyouahaskell:mainfrom
ftsimas wants to merge 2 commits intolearnyouahaskell:mainfrom
Conversation
ftsimas
requested review from
konsumlamm,
memowe,
smith558 and
xogcox
as code owners
smith558
approved these changes
Sep 6, 2023
Collaborator
|
Hey @ftsimas, thanks for your contribution! The PR is currently in conflict with master branch. If you have some time to fix the conflict, I can review, approve, and merge :) Thanks again for taking the time to update the doc. |
ulysses4ever
requested changes
Dec 17, 2025
Collaborator
ulysses4ever
left a comment
ulysses4ever
left a comment
There was a problem hiding this comment.
This has been fixed in the meantime. @ftsimas , can you confirm if this PR isn't needed anymore? Thanks for the contribution anyway!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change in PR #51 from
transpose ["hey","there","guys"]totranspose ["hey","there","folks"]does not address the corresponding change to the function's output. This pull request fixes that.An update has been performed in the
source_md/modules.mdfile, where["htg","ehu","yey","rs","e"]has been changed to["htf","eho","yel","rk","es"]. I then executedgenerate.sh, which produced the expected updates tomodules.htmlin thegenerated_htmlfolder, as well as formatting updates tomaking-our-own-types-and-typeclasses.html.Lastly, the updated html files were copied to theEdit: After reading #46 (comment), the changes on thedocsfolder.docsfolder have been reverted, and a manual fix ondocs/modules.htmlhas been applied.