Skip to content

Fixes breadcrumb wrapping and overlapping the select all box #4976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akolson merged 5 commits into from
May 15, 2025
Merged

Fixes breadcrumb wrapping and overlapping the select all box #4976

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
70bcc50
000
AllanOXDi Apr 15, 2025
2689524
prevents breadcrumbs overlapping the select all box
AllanOXDi Apr 17, 2025
29a0ca2
minor improvment
AllanOXDi May 7, 2025
410c928
revert the pilow down grade
AllanOXDi May 9, 2025
20fd624
clean up yarn
AllanOXDi May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions contentcuration/contentcuration/frontend/shared/views/Breadcrumbs.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,13 +108,13 @@
},
methods: {
handleOverflow() {
const maxWidth = this.$refs.breadcrumbs.$el.offsetWidth;
let totalWidth = 0;
this.breadcrumbStartingIndex = 0;
this.$nextTick(() => {
if (this.$refs.breadcrumb) {
if (this.$refs.breadcrumb && this.$refs.breadcrumb) {
const maxWidth = this.$refs.breadcrumbs.$el.offsetWidth;
for (var i = this.$refs.breadcrumb.length - 1; i >= 0; --i) {
totalWidth += this.$refs.breadcrumb[i].$el.offsetWidth + 40;
Copy link
Copy Markdown
Member

@akolson akolson Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, this still doesn't fix the issue. If anything, it would be a partial fix--in some screen sizes it works on others it doesn't

totalWidth += this.$refs.breadcrumb[i].$el.offsetWidth + 60;

// Bounds exceeded, go back to previous index
if (totalWidth >= maxWidth - 48) {
Expand Down