Skip to content

Clipboard - The icons and the checkboxes Misalignment fixed#4947

Merged
bjester merged 7 commits intolearningequality:unstablefrom
GautamBytes:fix-clipboard-alignment
Apr 2, 2025
Merged

Clipboard - The icons and the checkboxes Misalignment fixed#4947
bjester merged 7 commits intolearningequality:unstablefrom
GautamBytes:fix-clipboard-alignment

Conversation

@GautamBytes
Copy link
Copy Markdown
Contributor

Summary

  • Fixed checkbox alignment issues in the UI that were causing misalignment between checkbox icons and their corresponding text labels. The checkboxes were appearing slightly misaligned with channel names and folder items in different views.

  • The fix addresses the inconsistent vertical positioning that was affecting UI appearance

#Before -->
image

#After -->
image

References

Addresses #4771

Reviewer guidance

  • Check that checkbox alignment appears consistent in:
  • Channel listings (specifically Alpha channel view)
    • Folder and file listings
  • Content item selections
  • Verify that the changes don't affect checkbox functionality - selection behavior should remain the same
  • Test in different viewport sizes to ensure responsive behavior is maintained

@GautamBytes
Copy link
Copy Markdown
Contributor Author

GautamBytes commented Mar 11, 2025

Hi @bjester and @pcenov , due to some issues , I needed to setup repo locally again and lost track of that branch so , raising this pr to fix the issue via more localize fix rather than updating the checkbox.vue itself , you can have a look and see if it fixes the issue. Thanks!

@MisRob
Copy link
Copy Markdown
Member

MisRob commented Mar 17, 2025

Thanks for following up @GautamBytes. Visually this looks definitely better than before. Code-wise, @bjester I think it addresses your feedback #4923, is that right?

@GautamBytes Would it be possible to fine-tune the styling so that checkbox center is vertically aligned with channel/folder/resource center? From the screenshots it seems checkbox is rather aligned to the bottom of the icon right now.

@MisRob MisRob requested review from MisRob and bjester March 17, 2025 09:34
@GautamBytes
Copy link
Copy Markdown
Contributor Author

Sure @MisRob , will try to make it vetically aligned!

@GautamBytes
Copy link
Copy Markdown
Contributor Author

Hi @MisRob , I tried many permutations and combinations to see if this get vertically aligned with channel/folder/resource center but failed till now . When i zoom a bit(as you can see in image attached , it does not look like aligned with bottom of icons ) but yeah at first sight it definitely looks bottom aligned . I guess slightly decreasing checkbox size might make it look like that but as @bjester suggested not to change checkbox.vue , I guess this one is good to go . Would be happy if you can suggest what else can i do to achieve so:)

image

@MisRob
Copy link
Copy Markdown
Member

MisRob commented Mar 18, 2025

@GautamBytes Thanks for continuing. Few guiding questions that may help us to figure out what to do next:

  • Are those pt- classes applied or not?
  • If not, why (overriden from somewhere else, ...)?
  • If yes, perhaps pt-s are not nuanced enough and we need to use precise px value?
  • If none of these, what's going on exactly?

Yes I think @bjester's request to not modify the checkbox itself makes sense. Also, there are some things on KDS side that Blaine reported that may help a bit here too if we get block, but I hope we can improve in the scope of this PR.

In any case, I don't consider this feedback as blocking. It looks much better already than originally. @bjester how does the new screenshot look like to you?

@MisRob MisRob self-assigned this Mar 25, 2025
@GautamBytes
Copy link
Copy Markdown
Contributor Author

GautamBytes commented Mar 26, 2025

Hi @MisRob , sorry for following up late on this , I tried your suggestions and it seems to me that 3rd point give us the expected result . It looks like this now --

image

@GautamBytes
Copy link
Copy Markdown
Contributor Author

Hey @MisRob & @bjester , just pinging if you can have a review otherwise no worries , review at your convenience!

@MisRob
Copy link
Copy Markdown
Member

MisRob commented Apr 1, 2025

Hi @GautamBytes, I'm sorry for late reply. Yes the new screenshots looks very nice. I will follow-up later with full review, for now you can keep it as is. Thank you.

Copy link
Copy Markdown
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GautamBytes !

@bjester bjester merged commit 28ddc2b into learningequality:unstable Apr 2, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants