Fix/155 windows default skin#157
Open
kujirahand wants to merge 9 commits intomainfrom
Open
Conversation
- Change Button use_ttk_buttons default behavior to True on Windows when omitted - Keep explicit use_ttk_buttons=True/False behavior unchanged - Keep Windows default theme as vista and document theme usage/customization - Add docs/theme.md and link it from docs/README.md - Add tests/theme/ttk_button.py example and lint docstring fix
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates TkEasyGUI’s theme/button styling defaults and adds user-facing documentation and a demo script to help compare ttk vs classic tk button rendering across platforms.
Changes:
- Switches
Buttonto default tottk.Buttonrendering (use_ttk_buttons=True) and expands theButtondocstring with platform-specific styling limitations. - Clarifies default theme selection per platform (
aquaon macOS,vistaon Windows,clamotherwise) and cleans up related comments. - Adds a new Theme Guide (
docs/theme.md) and a demo script (tests/theme/ttk_button.py), and links the guide from docs/README.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
tests/theme/ttk_button.py |
Adds a small demo script to compare ttk vs classic buttons. |
docs/theme.md |
Introduces a Theme Guide covering theme selection and button style options. |
docs/README.md |
Links the new Theme Guide from the documentation index. |
TkEasyGUI/widgets_window.py |
Adds comments clarifying theme defaults and available theme names by OS in root creation. |
TkEasyGUI/widgets.py |
Changes Button(use_ttk_buttons=...) default to True and documents platform limitations. |
TkEasyGUI/utils.py |
Removes stale commented-out theme defaults and keeps Windows default theme as vista. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
Agent-Logs-Url: https://github.com/kujirahand/tkeasygui-python/sessions/5529a64b-e51e-4a12-a682-716cdc1177c8 Co-authored-by: kujirahand <[email protected]>
…x/155-windows-default-skin
…tkeasygui-python into fix/155-windows-default-skin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the theme management for TkEasyGUI, making it easier for users to understand and control widget appearance across platforms. The main changes include setting
ttkbuttons as the default for a more modern look, providing detailed documentation on theme usage, and adding a test script to compare button styles.Theme management and defaults:
Buttonwidget to usettkbuttons (use_ttk_buttons=True), resulting in a modern appearance by default. Platform-specific notes and limitations (e.g., background color and height settings) are now documented in the class docstring. [1] [2]aquafor macOS,vistafor Windows,clamfor others) in bothset_default_themeand window creation. [1] [2]Documentation improvements:
docs/theme.mdguide explaining theme usage, available themes, button style options, and customization for TkEasyGUI.Buttonwidget docstring with usage notes and platform-specific guidance. [1] [2]Testing:
tests/theme/ttk_button.pyto demonstrate and compare modern (ttk) and classic (tk) button appearances.