Merge pull request #103 from kokarare1212/deepsource-fix-3f1e7803

Iterate dictionary directly

Author: kokarare1212

librespot/core.py

@@ -237,15 +237,15 @@ def __init__(self, session: Session):
     def add_message_listener(self, listener: MessageListener,
                              uris: list[str]) -> None:
         with self.__message_listeners_lock:
-            if listener in self.__message_listeners.keys():
+            if listener in self.__message_listeners:
                 raise TypeError(
                     "A listener for {} has already been added.".format(uris))
             self.__message_listeners[listener] = uris
             self.__message_listeners_lock.notify_all()
 
     def add_request_listener(self, listener: RequestListener, uri: str):
         with self.__request_listeners_lock:
-            if uri in self.__request_listeners.keys():
+            if uri in self.__request_listeners:
                 raise TypeError(
                     "A listener for '{}' has already been added.".format(uri))
             self.__request_listeners[uri] = listener
@@ -289,7 +289,7 @@ def handle_message(self, obj: typing.Any) -> None:
             decoded_payloads = b""
         interesting = False
         with self.__message_listeners_lock:
-            for listener in self.__message_listeners.keys():
+            for listener in self.__message_listeners:
                 dispatched = False
                 keys = self.__message_listeners.get(listener)
                 for key in keys:
@@ -320,7 +320,7 @@ def handle_request(self, obj: typing.Any) -> None:
             .format(mid, key, pid, sender, command))
         interesting = False
         with self.__request_listeners_lock:
-            for mid_prefix in self.__request_listeners.keys():
+            for mid_prefix in self.__request_listeners:
                 if mid.startswith(mid_prefix):
                     listener = self.__request_listeners.get(mid_prefix)
                     interesting = True

librespot/crypto.py

@@ -168,8 +168,7 @@ class Type:
         @staticmethod
         def parse(val: typing.Union[bytes, None]) -> typing.Union[bytes, None]:
             for cmd in [
-                    Packet.Type.__dict__[attr]
-                    for attr in Packet.Type.__dict__.keys()
+                    Packet.Type.__dict__[attr] for attr in Packet.Type.__dict__
                     if re.search("__.+?__", attr) is None
                     and type(Packet.Type.__dict__[attr]) is bytes
             ]: