Skip to content

Commit 6c6fe37

Browse files
committed
Fix deepsource issue(s)
1 parent 4f51d3a commit 6c6fe37

3 files changed

Lines changed: 10 additions & 5 deletions

File tree

librespot/audio/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
from librespot.crypto import Packet
88
from librespot.metadata import EpisodeId, PlayableId, TrackId
99
from librespot.proto import Metadata_pb2 as Metadata, StorageResolve_pb2 as StorageResolve
10-
from librespot.structure import AudioDecrypt, AudioQualityPicker, Closeable, GeneralAudioStream, GeneralWritableStream, HaltListener, NoopAudioDecrypt, PacketsReceiver
10+
from librespot.structure import AudioDecrypt, AudioQualityPicker, Closeable, FeederException, GeneralAudioStream, GeneralWritableStream, HaltListener, NoopAudioDecrypt, PacketsReceiver
1111
import concurrent.futures
1212
import io
1313
import logging
@@ -779,7 +779,7 @@ def load_track(self, track_id_or_track: typing.Union[TrackId,
779779
self.logger.fatal(
780780
"Couldn't find any suitable audio file, available: {}".format(
781781
track.file))
782-
raise
782+
raise FeederException()
783783
return self.load_stream(file, track, None, preload, halt_listener)
784784

785785
def pick_alternative_if_necessary(

librespot/core.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -343,10 +343,11 @@ def remove_message_listener(self, listener: MessageListener) -> None:
343343

344344
def remove_request_listener(self, listener: RequestListener) -> None:
345345
with self.__request_listeners_lock:
346+
request_listeners = {}
346347
for key, value in self.__request_listeners.items():
347-
if value == listener:
348-
self.__request_listeners.pop(key)
349-
break
348+
if value != listener:
349+
request_listeners[key] = value
350+
self.__request_listeners = request_listeners
350351

351352
def wait_for_listener(self) -> None:
352353
with self.__message_listeners_lock:

librespot/structure.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,10 @@ def close(self) -> None:
2929
raise NotImplementedError
3030

3131

32+
class FeederException(Exception):
33+
pass
34+
35+
3236
class GeneralAudioStream:
3337
def stream(self) -> AbsChunkedInputStream:
3438
raise NotImplementedError

0 commit comments

Comments
 (0)