feat: add configurable stop timeout for ContainerGuard cleanup#228
Merged
joshrotenberg merged 1 commit intomainfrom Jan 6, 2026
Merged
feat: add configurable stop timeout for ContainerGuard cleanup#228joshrotenberg merged 1 commit intomainfrom
joshrotenberg merged 1 commit intomainfrom
Conversation
Adds stop_timeout option to ContainerGuard for configuring how long
Docker waits before sending SIGKILL during cleanup.
Changes:
- Add stop_timeout field to GuardOptions (Option<Duration>)
- Add stop_timeout() builder method to ContainerGuardBuilder
- Use timeout in Drop implementation for both runtime contexts
Use cases:
- Fast test cleanup with short timeout (e.g., 1 second)
- Longer timeout for containers needing graceful shutdown
- Duration::ZERO for immediate SIGKILL
Example:
let guard = ContainerGuard::new(template)
.stop_timeout(Duration::from_secs(1))
.start()
.await?;
Closes #221
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds configurable timeout for stop operations during ContainerGuard cleanup/drop.
Closes #221
Changes
stop_timeoutfield toGuardOptions(Option<Duration>)stop_timeout()builder method toContainerGuardBuilderDropimplementation for both runtime contextsAPI
Use Cases
Tests
Added 2 integration tests:
test_container_guard_stop_timeout- 1 second timeouttest_container_guard_stop_timeout_zero- immediate SIGKILL