feat: add with_network() support to ContainerGuard#226
Merged
joshrotenberg merged 1 commit intomainfrom Jan 5, 2026
Merged
Conversation
- Add with_network() builder method to attach container to a network - Add create_network option (default: true) to auto-create network - Add remove_network_on_drop option to clean up network on drop - Add network() getter to retrieve configured network name - Network is created with bridge driver if it doesn't exist - Network cleanup only happens if guard created the network Closes #219
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #219. Adds network support to
ContainerGuardfor multi-container test scenarios.New Builder Methods
with_network(name)Attach the container to a Docker network:
create_network(bool)Control automatic network creation (default: true):
remove_network_on_drop(bool)Clean up the network when the guard drops (default: false):
network()getterGet the configured network name:
Behavior
create_networkis true)Testing
Closes #219