test: add command execution verification tests#181
Merged
joshrotenberg merged 1 commit intomainfrom Dec 11, 2025
Merged
Conversation
- Add tests to verify build_command_args() returns command name as first element - Fix ImagesCommand which was missing 'images' in build_command_args() - This would have caused 'docker docker' bug for images command - 40 tests covering all major commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds tests to catch bugs like the
docker dockerissue (#176, fixed in #180).Changes
New test file:
tests/command_execution_test.rswith 40 tests verifying each command'sbuild_command_args()returns the command name as the first element (not 'docker').Bug fix:
ImagesCommand::build_command_args()was missing 'images' as the first element. This would have caused the samedocker dockerbug for the images command.Why This Helps
These tests ensure that:
build_command_args()docker dockergenerated byPullCommand#176 is caught at test timeTest Coverage
Tests added for: attach, build, commit, cp, create, diff, events, exec, export, history, images, import, info, inspect, kill, load, login, logout, logs, pause, port, ps, pull, push, rename, restart, rm, rmi, run, save, search, start, stats, stop, tag, top, unpause, update, version, wait