test(no-nested-interactive): add composite-widget hierarchy valid cases#62
Closed
test(no-nested-interactive): add composite-widget hierarchy valid cases#62
Conversation
Covers the canonical ARIA composite-widget patterns driven by COMPOSITE_WIDGET_CHILDREN (aria-query requiredOwnedElements — already on master via lib/utils/interactive-roles.js): listbox>option, tablist>tab, tree>treeitem, grid>row>gridcell/rowheader/columnheader, treegrid>row, radiogroup>radio. Added to both the gts and hbs rule-tester runs.
🏎️ Benchmark Comparison
Full mitata output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
listbox > option,tablist > tab,tree > treeitem,grid > row > gridcell/rowheader/columnheader,treegrid > row > gridcell,radiogroup > radio.COMPOSITE_WIDGET_CHILDREN(already on master inlib/utils/interactive-roles.js, derived from aria-query'srequiredOwnedElements). The tests confirm that derivation is wired up correctly in the rule and none of these patterns produce a false positive.Test plan
vitest run tests/lib/rules/template-no-nested-interactive.js— 109 tests pass (was 101 before)