forked from ember-cli/eslint-plugin-ember
-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add template-no-noninteractive-tabindex #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
johanrd
wants to merge
20
commits into
master
Choose a base branch
from
feat/template-no-noninteractive-tabindex
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
9e8e45e
Prepare Release v13.1.4 using 'release-plan'
github-actions[bot] 0cf348b
Merge pull request #2750 from ember-cli/release-preview
NullVoxPopuli 148a2a3
feat: add template-require-input-type — reject invalid input types; o…
johanrd 675427a
Merge pull request #2763 from johanrd/html-validate/template-require-…
NullVoxPopuli 493f154
Update parser
NullVoxPopuli 4ae4688
Merge pull request #2766 from ember-cli/nvp/update-parser
NullVoxPopuli e5baa77
Prepare Release v13.2.0 using 'release-plan'
github-actions[bot] c52084a
Merge pull request #2765 from ember-cli/release-preview
NullVoxPopuli 6a8d7b7
docs: add glimmer-attribute-behavior reference
johanrd 6052bae
docs: cite ember-source 6.12, drop separate Glimmer version
johanrd 8c4c540
docs(glimmer-attribute-behavior): rewrite from verified empirical data
johanrd e0a8d17
fix(docs): use querySelector to satisfy unicorn/prefer-query-selector
johanrd 1b384a7
docs(glimmer-attribute-behavior): add "Reading attribute values in ru…
johanrd bb1ebb3
feat(utils): add glimmer-attr-presence — encodes the verified renderi…
johanrd bfb839d
fix(glimmer-attr-presence): correctness fixes + adopt property-inform…
johanrd 2abe309
feat: add template-no-noninteractive-tabindex
johanrd c833ac3
fix: use strict integer parsing for tabindex values (HTML spec § rule…
johanrd b1ed35a
test(template-no-noninteractive-tabindex): add GlimmerConcatStatement…
johanrd 06a4b94
fix: prettier formatting
johanrd ca9b971
fix: use classifyAttribute for tabindex presence (rows t6, t7)
johanrd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,22 @@ | ||
| { | ||
| "solution": { | ||
| "eslint-plugin-ember": { | ||
| "impact": "patch", | ||
| "oldVersion": "13.1.2", | ||
| "newVersion": "13.1.3", | ||
| "impact": "minor", | ||
| "oldVersion": "13.1.4", | ||
| "newVersion": "13.2.0", | ||
| "tagName": "latest", | ||
| "constraints": [ | ||
| { | ||
| "impact": "patch", | ||
| "reason": "Appears in changelog section :bug: Bug Fix" | ||
| "impact": "minor", | ||
| "reason": "Appears in changelog section :rocket: Enhancement" | ||
| }, | ||
| { | ||
| "impact": "patch", | ||
| "reason": "Appears in changelog section :house: Internal" | ||
| "reason": "Appears in changelog section :bug: Bug Fix" | ||
| } | ||
| ], | ||
| "pkgJSONPath": "./package.json" | ||
| } | ||
| }, | ||
| "description": "## Release (2026-04-25)\n\n* eslint-plugin-ember 13.1.3 (patch)\n\n#### :bug: Bug Fix\n* `eslint-plugin-ember`\n * [#2730](https://github.com/ember-cli/eslint-plugin-ember/pull/2730) BUGFIX: template-require-valid-alt-text — reject empty-string aria-label/labelledby/alt on <input type=image>, <object>, <area> ([@johanrd](https://github.com/johanrd))\n * [#2729](https://github.com/ember-cli/eslint-plugin-ember/pull/2729) BUGFIX: template-no-invalid-role — support DPUB/Graphics-ARIA and role-fallback lists ([@johanrd](https://github.com/johanrd))\n * [#2726](https://github.com/ember-cli/eslint-plugin-ember/pull/2726) BUGFIX: template-no-unsupported-role-attributes — honor aria-query attribute constraints ([@johanrd](https://github.com/johanrd))\n * [#2727](https://github.com/ember-cli/eslint-plugin-ember/pull/2727) BUGFIX: template-no-redundant-role — case-insensitive match + <select>→combobox ([@johanrd](https://github.com/johanrd))\n\n#### :house: Internal\n* `eslint-plugin-ember`\n * [#2746](https://github.com/ember-cli/eslint-plugin-ember/pull/2746) refactor: extract isNativeElement util (fix component-vs-HTML-tag misclassification) ([@johanrd](https://github.com/johanrd))\n\n#### Committers: 1\n- [@johanrd](https://github.com/johanrd)\n" | ||
| "description": "## Release (2026-04-28)\n\n* eslint-plugin-ember 13.2.0 (minor)\n\n#### :rocket: Enhancement\n* `eslint-plugin-ember`\n * [#2763](https://github.com/ember-cli/eslint-plugin-ember/pull/2763) feat: add template-require-input-type ([@johanrd](https://github.com/johanrd))\n\n#### :bug: Bug Fix\n* `eslint-plugin-ember`\n * [#2766](https://github.com/ember-cli/eslint-plugin-ember/pull/2766) Update parser ([@NullVoxPopuli](https://github.com/NullVoxPopuli))\n\n#### Committers: 2\n- [@NullVoxPopuli](https://github.com/NullVoxPopuli)\n- [@johanrd](https://github.com/johanrd)\n" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| # ember/template-no-noninteractive-tabindex | ||
|
|
||
| <!-- end auto-generated rule header --> | ||
|
|
||
| Disallow `tabindex` on non-interactive elements. | ||
|
|
||
| Adding `tabindex="0"` to a `<div>`, `<section>`, etc. puts it in the keyboard tab order without supplying any keyboard semantics — users reach the element but have no way to operate it, and screen readers announce the tag with no hint of interactivity. | ||
|
|
||
| If the element is meant to be interactive, give it an explicit ARIA role (`button`, `checkbox`, …) **and** wire up the appropriate keyboard event handlers. If it isn't meant to be interactive, remove the tabindex. | ||
|
|
||
| `tabindex="-1"` is exempt — it marks an element as programmatically focusable but skipped by the Tab key, the canonical pattern for scroll-to-focus targets, focus restoration, and composite-widget children. See [`template-require-aria-activedescendant-tabindex`](./template-require-aria-activedescendant-tabindex.md). | ||
|
|
||
| `<canvas>` is always exempt. The HTML spec does not classify `<canvas>` as interactive content, but it is routinely used as an interactive drawing or game surface, and `tabindex` is required to make it keyboard-accessible. Flagging `<canvas tabindex="0">` would produce unhelpful noise for these legitimate use-cases. | ||
|
|
||
| ## Examples | ||
|
|
||
| This rule **forbids** the following: | ||
|
|
||
| ```gjs | ||
| <template> | ||
| <div tabindex="0"></div> | ||
| <article tabindex="0">Story</article> | ||
| <div role="article" tabindex="0"></div> | ||
| <a tabindex="0">Not a link (missing href)</a> | ||
| </template> | ||
| ``` | ||
|
|
||
| This rule **allows** the following: | ||
|
|
||
| ```gjs | ||
| <template> | ||
| {{! Interactive native elements }} | ||
| <button tabindex="0">Click</button> | ||
| <a href="/x" tabindex="0">Link</a> | ||
| <input tabindex="-1" /> | ||
|
|
||
| {{! Non-interactive element with an interactive ARIA role }} | ||
| <div role="button" tabindex="0"></div> | ||
| <div role="checkbox" tabindex="0" aria-checked="false"></div> | ||
|
|
||
| {{! tabindex="-1" — focusable but not in tab order }} | ||
| <div tabindex="-1"></div> | ||
| <section tabindex="-1">scroll target</section> | ||
|
|
||
| {{! Dynamic role — conservatively skipped }} | ||
| <div role={{this.role}} tabindex="0"></div> | ||
|
|
||
| {{! role="tabpanel" — default allowlist (see Options) }} | ||
| <div role="tabpanel" tabindex="0" aria-labelledby="tab-1">Panel</div> | ||
|
|
||
| {{! <canvas> — exempted because canvas needs tabindex to be keyboard-accessible }} | ||
| <canvas tabindex="0"></canvas> | ||
| </template> | ||
| ``` | ||
|
|
||
| ## Options | ||
|
|
||
| - `roles` (default `["tabpanel"]`) — non-interactive ARIA roles exempted from this rule. Elements carrying one of these roles may have `tabindex` without triggering a flag. | ||
|
|
||
| The default value (`["tabpanel"]`) matches jsx-a11y's recommended config. The [WAI-ARIA APG Tabs pattern](https://www.w3.org/WAI/ARIA/apg/patterns/tabs/) gives panels `tabindex="0"` when the panel's content isn't itself focusable, so keyboard users can page through panels. Flagging tabpanel-with-tabindex as a violation would break the canonical Tabs pattern. | ||
|
|
||
| Use an empty array (`roles: []`) to disable the default exemption — matching jsx-a11y's strict config. Use a wider list (e.g. `roles: ["tabpanel", "region"]`) to exempt additional roles where your project uses `tabindex` legitimately (scrollable regions, etc.). | ||
|
|
||
| ## References | ||
|
|
||
| - [WAI-ARIA Authoring Practices — Keyboard Interaction](https://www.w3.org/WAI/ARIA/apg/practices/keyboard-interface/) | ||
| - [MDN — tabindex](https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Global_attributes/tabindex) | ||
| - [`no-noninteractive-tabindex` — eslint-plugin-jsx-a11y](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/docs/rules/no-noninteractive-tabindex.md) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| # ember/template-require-input-type | ||
|
|
||
| 🔧 This rule is automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/latest/user-guide/command-line-interface#--fix). | ||
|
|
||
| <!-- end auto-generated rule header --> | ||
|
|
||
| This rule rejects `<input type="...">` values that are not one of the input | ||
| types defined by the HTML spec, and (optionally) requires every `<input>` to | ||
| declare a `type` attribute. | ||
|
|
||
| An invalid value like `<input type="foo">` silently falls back to the Text | ||
| state — the browser reports no error, but the author's intent (validation, | ||
| inputmode hint, platform keyboard) is lost. That's a genuine silent-failure | ||
| class, which this rule always flags and auto-fixes to `type="text"`. | ||
|
|
||
| A missing `type` attribute (`<input />`) is _spec-compliant_ — the | ||
| missing-value default is the Text state — so flagging it is a style / | ||
| consistency choice, not a correctness one. Opt in with `requireExplicit: true` | ||
| if your team wants parity with `template-require-button-type`. | ||
|
|
||
| ## Examples | ||
|
|
||
| This rule **forbids** the following (always): | ||
|
|
||
| ```hbs | ||
| <input type='' /> | ||
| <input type='foo' /> | ||
| <input type='TEXTY' /> | ||
| ``` | ||
|
|
||
| With `requireExplicit: true` the rule **also forbids**: | ||
|
|
||
| ```hbs | ||
| <input /> | ||
| <input name='email' /> | ||
| ``` | ||
|
|
||
| This rule **allows** the following: | ||
|
|
||
| ```hbs | ||
| <input type='text' /> | ||
| <input type='email' /> | ||
| <input type='checkbox' /> | ||
| <input type={{this.inputType}} /> | ||
| ``` | ||
|
|
||
| Dynamic values such as `type={{this.inputType}}` are not flagged at lint time. | ||
|
|
||
| ## Configuration | ||
|
|
||
| - `requireExplicit` (`boolean`, default `false`): when true, also flag | ||
| `<input>` elements that have no `type` attribute. Auto-fix inserts | ||
| `type="text"`. | ||
|
|
||
| ```js | ||
| module.exports = { | ||
| rules: { | ||
| 'ember/template-require-input-type': ['error', { requireExplicit: true }], | ||
| }, | ||
| }; | ||
| ``` | ||
|
|
||
| ## References | ||
|
|
||
| - [HTML spec — the input element](https://html.spec.whatwg.org/multipage/input.html#the-input-element) | ||
| - Adapted from [`html-validate`'s `no-implicit-input-type`](https://html-validate.org/rules/no-implicit-input-type.html) (MIT). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.