Fix Required Builds merge check by switching to repo-scoped Bitbucket…#460
Open
asmild wants to merge 2 commits intojenkinsci:release/1.xfrom
Open
Fix Required Builds merge check by switching to repo-scoped Bitbucket…#460asmild wants to merge 2 commits intojenkinsci:release/1.xfrom
asmild wants to merge 2 commits intojenkinsci:release/1.xfrom
Conversation
1263a4d to
491e0df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use repo-scoped Bitbucket builds API to fix Required Builds merge check
The plugin currently uses the deprecated
/rest/build-status/1.0/commits/{sha}endpoint,which does not work with Bitbucket's "Required Builds" merge check — builds appear on
commits but are not recognized as satisfying merge requirements.
This PR switches to the repo-scoped
/rest/api/latest/projects/{project}/repos/{repo}/commits/{sha}/buildsendpoint and adds the
parentfield to the payload.Changes:
BuildStatusUriFactory.create()overload for repo-scoped APIparentfield to notification payload (required for Required Builds matching)Testing done
Submitter checklist