Skip to content

Commit 1b5be0b

Browse files
committed
Add missing nullability annotation and replace JSR 305
1 parent 0b69258 commit 1b5be0b

3 files changed

Lines changed: 7 additions & 5 deletions

File tree

src/main/java/org/jenkinsci/plugins/parameterizedscheduler/DescriptorImpl.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
package org.jenkinsci.plugins.parameterizedscheduler;
22

33
import static hudson.Util.fixNull;
4+
5+
import edu.umd.cs.findbugs.annotations.NonNull;
46
import hudson.Extension;
57
import hudson.model.Item;
68
import hudson.model.AbstractProject;
@@ -38,6 +40,7 @@ public boolean isApplicable(Item item) {
3840
return result;
3941
}
4042

43+
@NonNull
4144
@Override
4245
public String getDisplayName() {
4346
return Messages.ParameterizedTimerTrigger_DisplayName();

src/main/java/org/jenkinsci/plugins/parameterizedscheduler/ParameterParser.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
package org.jenkinsci.plugins.parameterizedscheduler;
22

33
import com.google.common.base.Splitter;
4+
import edu.umd.cs.findbugs.annotations.CheckForNull;
45
import hudson.model.ParametersDefinitionProperty;
56
import org.apache.commons.lang.StringUtils;
67

7-
import javax.annotation.CheckForNull;
88
import java.util.Collections;
99
import java.util.List;
1010
import java.util.Map;

src/test/java/org/jenkinsci/plugins/parameterizedscheduler/ParameterizedSchedulerTest.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package org.jenkinsci.plugins.parameterizedscheduler;
22

3+
import edu.umd.cs.findbugs.annotations.CheckForNull;
4+
import edu.umd.cs.findbugs.annotations.NonNull;
35
import hudson.model.FreeStyleProject;
46
import hudson.model.Job;
57
import hudson.model.ParameterDefinition;
@@ -18,9 +20,6 @@
1820
import org.jvnet.hudson.test.JenkinsRule;
1921
import org.kohsuke.stapler.StaplerRequest;
2022

21-
import javax.annotation.CheckForNull;
22-
import javax.annotation.Nonnull;
23-
2423
import java.util.ArrayList;
2524
import java.util.List;
2625

@@ -144,7 +143,7 @@ public void nullValueCreated() throws Exception {
144143

145144
private static class NullParameterDefinition extends ParameterDefinition {
146145

147-
public NullParameterDefinition(@Nonnull String name) {
146+
public NullParameterDefinition(@NonNull String name) {
148147
super(name, null);
149148
}
150149

0 commit comments

Comments
 (0)