Remove not thrown exception declarations

offa · offa · commit 0b69258258c1 · 2021-12-16T09:24:13.000+01:00
diff --git a/src/main/java/org/jenkinsci/plugins/parameterizedscheduler/Cron.java b/src/main/java/org/jenkinsci/plugins/parameterizedscheduler/Cron.java
@@ -29,7 +29,7 @@ public long getInitialDelay() {
 	}
 
 	@Override
-	protected void doRun() throws Exception {
+	protected void doRun() {
 		Jenkins instance = Jenkins.get();
 
 		for (AbstractProject<?, ?> project : instance.allItems(AbstractProject.class)) {
diff --git a/src/main/java/org/jenkinsci/plugins/parameterizedscheduler/ParameterizedStaplerRequest.java b/src/main/java/org/jenkinsci/plugins/parameterizedscheduler/ParameterizedStaplerRequest.java
@@ -66,7 +66,7 @@ public String getHeader(String name) {
 	}
 
 	@Override
-	public <T extends HttpUpgradeHandler> T upgrade(Class<T> handlerClass) throws IOException, ServletException {
+	public <T extends HttpUpgradeHandler> T upgrade(Class<T> handlerClass) {
 		return null;
 	}
 
@@ -183,27 +183,27 @@ public boolean isRequestedSessionIdFromUrl() {
 	}
 
 	@Override
-	public boolean authenticate(HttpServletResponse response) throws IOException, ServletException {
+	public boolean authenticate(HttpServletResponse response) {
 		return false;
 	}
 
 	@Override
-	public void login(String username, String password) throws ServletException {
+	public void login(String username, String password) {
 
 	}
 
 	@Override
-	public void logout() throws ServletException {
+	public void logout() {
 
 	}
 
 	@Override
-	public Collection<Part> getParts() throws IOException, ServletException {
+	public Collection<Part> getParts() {
 		return null;
 	}
 
 	@Override
-	public Part getPart(String name) throws IOException, ServletException {
+	public Part getPart(String name) {
 		return null;
 	}
 
@@ -224,7 +224,7 @@ public String getCharacterEncoding() {
 	}
 
 	@Override
-	public void setCharacterEncoding(String env) throws UnsupportedEncodingException {
+	public void setCharacterEncoding(String env) {
 
 	}
 
@@ -244,7 +244,7 @@ public String getContentType() {
 	}
 
 	@Override
-	public ServletInputStream getInputStream() throws IOException {
+	public ServletInputStream getInputStream() {
 		return null;
 	}
 
@@ -291,7 +291,7 @@ public int getServerPort() {
 	}
 
 	@Override
-	public BufferedReader getReader() throws IOException {
+	public BufferedReader getReader() {
 		return null;
 	}
 
@@ -427,18 +427,18 @@ public StringBuffer getRequestURLWithQueryString() {
 	}
 
 	@Override
-	public RequestDispatcher getView(Object it, String viewName) throws IOException {
+	public RequestDispatcher getView(Object it, String viewName) {
 		return null;
 	}
 
 	@SuppressWarnings("rawtypes")
 	@Override
-	public RequestDispatcher getView(Class clazz, String viewName) throws IOException {
+	public RequestDispatcher getView(Class clazz, String viewName) {
 		return null;
 	}
 
 	@Override
-	public RequestDispatcher getView(Klass<?> clazz, String viewName) throws IOException {
+	public RequestDispatcher getView(Klass<?> clazz, String viewName) {
 		return null;
 	}
 
@@ -559,12 +559,12 @@ public BindInterceptor setBindListener(BindInterceptor bindListener) {
 	}
 
 	@Override
-	public JSONObject getSubmittedForm() throws ServletException {
+	public JSONObject getSubmittedForm() {
 		return null;
 	}
 
 	@Override
-	public FileItem getFileItem(String name) throws ServletException, IOException {
+	public FileItem getFileItem(String name) {
 		return null;
 	}
 
diff --git a/src/test/java/org/jenkinsci/plugins/parameterizedscheduler/ParameterParserTest.java b/src/test/java/org/jenkinsci/plugins/parameterizedscheduler/ParameterParserTest.java
@@ -94,15 +94,15 @@ public void test_ValueContainsEquals_emptyMap() {
 	}
 
 	@Test
-	public void checkSanity_HappyPath() throws Exception {
+	public void checkSanity_HappyPath() {
 		ParameterParser testObject = new ParameterParser();
 
 		Mockito.when(mockParametersDefinitionProperty.getParameterDefinitionNames()).thenReturn(Collections.singletonList("name"));
 		assertNull(testObject.checkSanity("* * * * *%name=value", mockParametersDefinitionProperty));
 	}
 
 	@Test
-	public void checkSanity_NotDefined_ProjectParameter() throws Exception {
+	public void checkSanity_NotDefined_ProjectParameter() {
 		ParameterParser testObject = new ParameterParser();
 
 		List<String> list = Collections.singletonList("not name");
@@ -112,7 +112,7 @@ public void checkSanity_NotDefined_ProjectParameter() throws Exception {
 	}
 
 	@Test
-	public void checkSanity_TrailingSemiColon_IsTrimmed() throws Exception {
+	public void checkSanity_TrailingSemiColon_IsTrimmed() {
 		ParameterParser testObject = new ParameterParser();
 
 		Mockito.when(mockParametersDefinitionProperty.getParameterDefinitionNames()).thenReturn(
@@ -121,21 +121,21 @@ public void checkSanity_TrailingSemiColon_IsTrimmed() throws Exception {
 	}
 
 	@Test
-	public void checkSanity_NoParametersIsNoBigDeal() throws Exception {
+	public void checkSanity_NoParametersIsNoBigDeal() {
 		ParameterParser testObject = new ParameterParser();
 
 		assertNull(testObject.checkSanity("* * * * *%", mockParametersDefinitionProperty));
 		assertNull(testObject.checkSanity("* * * * *", mockParametersDefinitionProperty));
 	}
 
 	@Test
-	public void checkSanity_duplicateParamName() throws Exception {
+	public void checkSanity_duplicateParamName() {
 		ParameterParser testObject = new ParameterParser();
 		assertTrue(testObject.checkSanity("* * * * *%name=value;name=value2", mockParametersDefinitionProperty).startsWith("Duplicate key"));
 	}
 
 	@Test
-	public void checkSanity_UnmatchedEquals() throws Exception {
+	public void checkSanity_UnmatchedEquals() {
 		ParameterParser testObject = new ParameterParser();
 		Mockito.when(mockParametersDefinitionProperty.getParameterDefinitionNames()).thenReturn(
 				Arrays.asList("name", "name2"));
@@ -144,7 +144,7 @@ public void checkSanity_UnmatchedEquals() throws Exception {
 	}
 
 	@Test
-	public void checkSanity_NullParameters() throws Exception {
+	public void checkSanity_NullParameters() {
 		ParameterParser testObject = new ParameterParser();
 		assertEquals(Messages.ParameterizedTimerTrigger_UndefinedParameter(Collections.singletonList("name"), Collections.emptyList()),
 				testObject.checkSanity("* * * * *%name=value", null));

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ public long getInitialDelay() {`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`@Override`
`32`		`- protected void doRun() throws Exception {`
	`32`	`+ protected void doRun() {`
`33`	`33`	`Jenkins instance = Jenkins.get();`
`34`	`34`
`35`	`35`	`for (AbstractProject<?, ?> project : instance.allItems(AbstractProject.class)) {`
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ public String getHeader(String name) {`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`@Override`
`69`		`- public <T extends HttpUpgradeHandler> T upgrade(Class<T> handlerClass) throws IOException, ServletException {`
	`69`	`+ public <T extends HttpUpgradeHandler> T upgrade(Class<T> handlerClass) {`
`70`	`70`	`return null;`
`71`	`71`	`}`
`72`	`72`
`@@ -183,27 +183,27 @@ public boolean isRequestedSessionIdFromUrl() {`
`183`	`183`	`}`
`184`	`184`
`185`	`185`	`@Override`
`186`		`- public boolean authenticate(HttpServletResponse response) throws IOException, ServletException {`
	`186`	`+ public boolean authenticate(HttpServletResponse response) {`
`187`	`187`	`return false;`
`188`	`188`	`}`
`189`	`189`
`190`	`190`	`@Override`
`191`		`- public void login(String username, String password) throws ServletException {`
	`191`	`+ public void login(String username, String password) {`
`192`	`192`
`193`	`193`	`}`
`194`	`194`
`195`	`195`	`@Override`
`196`		`- public void logout() throws ServletException {`
	`196`	`+ public void logout() {`
`197`	`197`
`198`	`198`	`}`
`199`	`199`
`200`	`200`	`@Override`
`201`		`- public Collection<Part> getParts() throws IOException, ServletException {`
	`201`	`+ public Collection<Part> getParts() {`
`202`	`202`	`return null;`
`203`	`203`	`}`
`204`	`204`
`205`	`205`	`@Override`
`206`		`- public Part getPart(String name) throws IOException, ServletException {`
	`206`	`+ public Part getPart(String name) {`
`207`	`207`	`return null;`
`208`	`208`	`}`
`209`	`209`
`@@ -224,7 +224,7 @@ public String getCharacterEncoding() {`
`224`	`224`	`}`
`225`	`225`
`226`	`226`	`@Override`
`227`		`- public void setCharacterEncoding(String env) throws UnsupportedEncodingException {`
	`227`	`+ public void setCharacterEncoding(String env) {`
`228`	`228`
`229`	`229`	`}`
`230`	`230`
`@@ -244,7 +244,7 @@ public String getContentType() {`
`244`	`244`	`}`
`245`	`245`
`246`	`246`	`@Override`
`247`		`- public ServletInputStream getInputStream() throws IOException {`
	`247`	`+ public ServletInputStream getInputStream() {`
`248`	`248`	`return null;`
`249`	`249`	`}`
`250`	`250`
`@@ -291,7 +291,7 @@ public int getServerPort() {`
`291`	`291`	`}`
`292`	`292`
`293`	`293`	`@Override`
`294`		`- public BufferedReader getReader() throws IOException {`
	`294`	`+ public BufferedReader getReader() {`
`295`	`295`	`return null;`
`296`	`296`	`}`
`297`	`297`
`@@ -427,18 +427,18 @@ public StringBuffer getRequestURLWithQueryString() {`
`427`	`427`	`}`
`428`	`428`
`429`	`429`	`@Override`
`430`		`- public RequestDispatcher getView(Object it, String viewName) throws IOException {`
	`430`	`+ public RequestDispatcher getView(Object it, String viewName) {`
`431`	`431`	`return null;`
`432`	`432`	`}`
`433`	`433`
`434`	`434`	`@SuppressWarnings("rawtypes")`
`435`	`435`	`@Override`
`436`		`- public RequestDispatcher getView(Class clazz, String viewName) throws IOException {`
	`436`	`+ public RequestDispatcher getView(Class clazz, String viewName) {`
`437`	`437`	`return null;`
`438`	`438`	`}`
`439`	`439`
`440`	`440`	`@Override`
`441`		`- public RequestDispatcher getView(Klass<?> clazz, String viewName) throws IOException {`
	`441`	`+ public RequestDispatcher getView(Klass<?> clazz, String viewName) {`
`442`	`442`	`return null;`
`443`	`443`	`}`
`444`	`444`
`@@ -559,12 +559,12 @@ public BindInterceptor setBindListener(BindInterceptor bindListener) {`
`559`	`559`	`}`
`560`	`560`
`561`	`561`	`@Override`
`562`		`- public JSONObject getSubmittedForm() throws ServletException {`
	`562`	`+ public JSONObject getSubmittedForm() {`
`563`	`563`	`return null;`
`564`	`564`	`}`
`565`	`565`
`566`	`566`	`@Override`
`567`		`- public FileItem getFileItem(String name) throws ServletException, IOException {`
	`567`	`+ public FileItem getFileItem(String name) {`
`568`	`568`	`return null;`
`569`	`569`	`}`
`570`	`570`