fix(JENKINS-71984): Matrix Authentication conflicting with NowSecure plugin after 3.2 upgrade#3
Open
dkieras-nowsecure wants to merge 4 commits intojenkinsci:masterfrom
Open
Conversation
…with the NowSecure Integration
…with the NowSecure Integration fix for unpublished artifact
…with the NowSecure Integration attempted fix to change unix paths in unit tests to universal pathing so as to support the Windows Ci...without a Windows machine
…with the NowSecure Integration attempted fix to change env vars that are dependent on Linux so as to support the Windows Ci...without a Windows machine
dylanhitt
approved these changes
Sep 20, 2023
dkieras-nowsecure
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jenkins auth-matrix plugin was updated, causing issues with the NowSecure Integration described in https://issues.jenkins.io/browse/JENKINS-71984
Addressed the misuse and conflict caused by the @symbol annotation values (specifically, 'group' caused the conflict with the auth matrix plugin).
Addressed the issue with reflection on incompatible property/getter naming pattern
Updated all unit tests to be filesystem-agnostic to comply with CI running in both Linux and Windows
Testing done
Tested against Jenkins locally after duplicating conflict and proving that this fix resolves it.