test: Add inversePrecedence regression tests#1013
Open
mPokornyETM wants to merge 4 commits intomasterfrom
Open
test: Add inversePrecedence regression tests#1013mPokornyETM wants to merge 4 commits intomasterfrom
mPokornyETM wants to merge 4 commits intomasterfrom
Conversation
mPokornyETM
force-pushed
the
test/inverse-precedence-861-864
branch
4 times, most recently
from
988bb7b to
e736ca9
Compare
Add two new tests to LockStepTest: - lockInverseOrderWithLabel: verifies inversePrecedence=true grants the lock to the newest build when locking by label (JENKINS-40787, #861) - lockInverseOrderMixedDifferentJobs: verifies each waiting job's own inversePrecedence flag controls queue ordering when using separate pipeline jobs with mixed settings (JENKINS-41070, #864)
mPokornyETM
force-pushed
the
test/inverse-precedence-861-864
branch
from
e736ca9 to
0b67e95
Compare
Extract lockInverseOrderWithLabel and lockInverseOrderMixedDifferentJobs into LockStepInversePrecedenceTest to keep LockStepTest smaller and avoid CI timeouts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add two regression tests to
LockStepTestthat confirm the inversePrecedence queue-ordering bugs reported in #861 (JENKINS-40787) and #864 (JENKINS-41070) are resolved.New tests
lockInverseOrderWithLabelinversePrecedence=truegrants the lock to the newest build when locking by label (b1 → b3 → b2)lockInverseOrderMixedDifferentJobsinversePrecedenceflag controls queue position, not the releasing job's flag. Uses separate pipeline jobs (pA#1 → pA#2 → pB#1 → pB#2)Testing done
All 31
LockStepTesttests pass locally (0 failures, 0 errors).Fixes #861
Fixes #864