Add strict export mode to propagate export failures as exceptions#2836
Open
somiljain2006 wants to merge 5 commits intojenkinsci:masterfrom
Open
Add strict export mode to propagate export failures as exceptions#2836somiljain2006 wants to merge 5 commits intojenkinsci:masterfrom
somiljain2006 wants to merge 5 commits intojenkinsci:masterfrom
Conversation
timja
reviewed
Apr 18, 2026
timja
reviewed
Apr 18, 2026
timja
reviewed
Apr 18, 2026
timja
reviewed
Apr 19, 2026
| public class CasCGlobalConfig extends GlobalConfiguration { | ||
|
|
||
| private String configurationPath; | ||
| private boolean strictExport = false; |
Member
There was a problem hiding this comment.
why do you need this in the global config? just get it from the context.
Contributor
Author
There was a problem hiding this comment.
I initially added strictExport to CasCGlobalConfig to allow configuring it via YAML, but that effectively makes it a persistent server setting.
Based on your suggestion, I plan to completely remove it from the global config (which means intentionally dropping the YAML configurability) and overload the export method to accept a ConfigurationContext directly.
This decouples the export logic from the global database. Let me know if you agree with this, and I’ll go ahead and update the implementation accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a strict export mode in ConfigurationAsCode that propagates export failures as ConfiguratorException instead of embedding "FAILED TO EXPORT" markers in the generated YAML.
This improves error visibility while maintaining backward compatibility.
Your checklist for this pull request
🚨 Please review the guidelines for contributing to this repository.