Skip to content

Resolve Descriptor generic type to derive natural names in DescriptorConfigurator#2834

Merged
timja merged 4 commits intojenkinsci:masterfrom
somiljain2006:descriptor-configurator-generic-type-resolution
Apr 16, 2026
Merged

Resolve Descriptor generic type to derive natural names in DescriptorConfigurator#2834
timja merged 4 commits intojenkinsci:masterfrom
somiljain2006:descriptor-configurator-generic-type-resolution

Conversation

@somiljain2006
Copy link
Copy Markdown
Contributor

@somiljain2006 somiljain2006 commented Apr 16, 2026

Derive Descriptor names from the generic type when @Symbolis absent. Resolve TODO in DescriptorConfigurator by extracting Descriptor type parameter to compute default camelCase names. Includes fallback handling and anonymous class support

Added unit tests covering:

  • @Symbol-based name resolution
  • Generic type extraction
  • Parameterized types
  • Deep inheritance hierarchies
  • Fallback behavior (including anonymous classes)

Your checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or in Jenkins JIRA
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Did you provide a test case? That demonstrates a feature works or fixes the issue.

@somiljain2006 somiljain2006 requested a review from a team as a code owner April 16, 2026 12:38
Copy link
Copy Markdown
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok

@timja timja added the feature A PR that adds a feature - used by Release Drafter label Apr 16, 2026
@timja timja enabled auto-merge (squash) April 16, 2026 20:37
@timja timja merged commit 41f1011 into jenkinsci:master Apr 16, 2026
17 checks passed
@somiljain2006 somiljain2006 deleted the descriptor-configurator-generic-type-resolution branch April 17, 2026 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature A PR that adds a feature - used by Release Drafter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants