Skip to content

Refactor SecretSourceResolver map initialization and clarify UpdateCenterConfigurator intent#2832

Merged
timja merged 1 commit intojenkinsci:masterfrom
somiljain2006:Update-centre-resolution
Apr 15, 2026
Merged

Refactor SecretSourceResolver map initialization and clarify UpdateCenterConfigurator intent#2832
timja merged 1 commit intojenkinsci:masterfrom
somiljain2006:Update-centre-resolution

Conversation

@somiljain2006
Copy link
Copy Markdown
Contributor

@somiljain2006 somiljain2006 commented Apr 15, 2026

Refactor map initialization in SecretSourceResolver by replacing the manual map.put usage with Map.of and removed outdated TODO in UpdateCenterConfigurator and clarified intent, since UpdateCenter is a Jenkins singleton and not a DataBound bean.

Your checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or in Jenkins JIRA
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Did you provide a test case? That demonstrates a feature that works or fixes the issue.

@somiljain2006 somiljain2006 requested a review from a team as a code owner April 15, 2026 02:06
@timja timja added the chore a PR that adds to maintenance - used by Release Drafter label Apr 15, 2026
@timja timja merged commit ac12440 into jenkinsci:master Apr 15, 2026
17 checks passed
@somiljain2006 somiljain2006 deleted the Update-centre-resolution branch April 15, 2026 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore a PR that adds to maintenance - used by Release Drafter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants